Skip to content

Fix ATS does not honor proxy.config.body_factory.response_max_size #4824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bryancall merged 1 commit into from
Jan 22, 2019
Merged

Fix ATS does not honor proxy.config.body_factory.response_max_size #4824

bryancall merged 1 commit into from
Jan 22, 2019

Conversation

@shinya1020
Copy link
Contributor

@shinya1020 shinya1020 commented Jan 17, 2019

proxy.config.body_factory.response_max_size was added by #1391 .
But it was broken by #1299 .

@maskit maskit added the Core label Jan 17, 2019
@maskit maskit added this to the 9.0.0 milestone Jan 17, 2019
@shinya1020 shinya1020 force-pushed the fix/body_factory_response_max_size branch from ac96581 to 4e1523a Compare January 17, 2019 09:48
@shinya1020
Copy link
Contributor Author

shinya1020 commented Jan 17, 2019 •
edited
Loading

I applied clang-format and squashed commits.

@bryancall
Copy link
Contributor

bryancall commented Jan 17, 2019

[approve ci autest]

masaori335
masaori335 approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@masaori335 masaori335 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@masaori335
Copy link
Contributor

masaori335 commented Jan 17, 2019

It looks like we need to backport this to 8.0.x, because #1299 is shipped on 8.0.0.

@SolidWallOfCode
Copy link
Member

SolidWallOfCode commented Jan 18, 2019

Not sure how #1299 broke #1391, since the former was committed before the latter, so the value didn't exist at the time of #1299.

@masaori335
Copy link
Contributor

masaori335 commented Jan 21, 2019

@SolidWallOfCode I'm afraid not. #1299 (d6c2a8) was marged after #1391 (d0e539).

$ git log --pretty=fuller | grep -A 6 -e "d6c2a82ed465f7a90980a76c23b52a6a37b9b310" -e "d0e5392d3399df2a67937b079928e357da43a273"
commit d6c2a82ed465f7a90980a76c23b52a6a37b9b310
Author:     Persia Aziz <[email protected]>
AuthorDate: Tue Jan 3 16:19:19 2017 -0600
Commit:     Alan M. Carroll <[email protected]>
CommitDate: Wed Mar 15 13:31:30 2017 -0500

    TS-2888: remove vararg and format parameters from build_error_resoponse
--
commit d0e5392d3399df2a67937b079928e357da43a273
Author:     Igor Brezac <[email protected]>
AuthorDate: Sun Jan 29 00:42:39 2017 +0000
Commit:     Bryan Call <[email protected]>
CommitDate: Mon Jan 30 16:49:47 2017 -0800

    Allow configurable body factory response max size

@bryancall bryancall merged commit 854324a into apache:master Jan 22, 2019
@SolidWallOfCode
Copy link
Member

SolidWallOfCode commented Jan 22, 2019

Ah, I looked at the author dates. Interesting there was no merge conflict detected.

@bryancall bryancall modified the milestones: 9.0.0, 8.0.3 Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bryancall bryancall bryancall approved these changes

@masaori335 masaori335 masaori335 approved these changes

Assignees

@shinya1020 shinya1020

Labels

Core

Projects

None yet

Milestone

8.0.3

Development

Successfully merging this pull request may close these issues.

5 participants

@shinya1020 @bryancall @masaori335 @SolidWallOfCode @maskit