-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[REFACTOR][TIR] Rename tir.Block to SBlock #18689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This PR renames tir.Block to SBlock. This clearly indicate the scheduable property of the block and is a prereq for followup stir passes refactor. This update focuses on data structure changes.
Summary of ChangesHello @tqchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant refactoring within the TensorIR (TIR) system by renaming the core Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the TIR codebase by renaming Block to SBlock and updating related classes and functions to use the new name. The code changes include modifications to the C++ code, Python bindings, and test cases. The review comments suggest updating docstrings and method names to reflect the change from Block to SBlock for consistency and clarity.
|
/gemini review |
|
Note The number of changes in this pull request is too large for Gemini Code Assist to generate a review. |
|
@tvm-bot rerun |
This PR renames tir.Block to SBlock. This clearly indicate the scheduable property of the block and is a prereq for followup stir passes refactor.
Main changes: