Skip to content

Commit 7f81482

Browse files
committed
Address comment, set no default value and add UT
1 parent a637279 commit 7f81482

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

client-spark/spark3/src/test/java/org/apache/spark/shuffle/DelegationRssShuffleManagerTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ public void testTryAccessCluster() throws Exception {
139139

140140
@Test
141141
public void testDefaultIncludeExcludeProperties() throws Exception {
142-
CoordinatorClient mockClient = setupMockedRssShuffleUtils(SUCCESS);
142+
final CoordinatorClient mockClient = setupMockedRssShuffleUtils(SUCCESS);
143143
SparkConf conf = new SparkConf();
144144
conf.set(RssSparkConfig.RSS_CLIENT_ACCESS_RETRY_INTERVAL_MS, 3000L);
145145
conf.set(RssSparkConfig.RSS_CLIENT_ACCESS_RETRY_TIMES, 3);
@@ -148,7 +148,7 @@ public void testDefaultIncludeExcludeProperties() throws Exception {
148148
conf.set(RssSparkConfig.RSS_COORDINATOR_QUORUM.key(), "m1:8001,m2:8002");
149149
conf.set("spark.rss.storage.type", StorageType.LOCALFILE.name());
150150
conf.set(RssSparkConfig.RSS_TEST_MODE_ENABLE, true);
151-
int confInitKeyCount = conf.getAll().length;
151+
final int confInitKeyCount = conf.getAll().length;
152152
assertCreateRssShuffleManager(conf);
153153

154154
// default case: access cluster should include all properties in conf and an extra one.
@@ -162,7 +162,7 @@ public void testDefaultIncludeExcludeProperties() throws Exception {
162162

163163
@Test
164164
public void testIncludeProperties() throws Exception {
165-
CoordinatorClient mockClient = setupMockedRssShuffleUtils(SUCCESS);
165+
final CoordinatorClient mockClient = setupMockedRssShuffleUtils(SUCCESS);
166166
SparkConf conf = new SparkConf();
167167
conf.set(RssSparkConfig.RSS_CLIENT_ACCESS_RETRY_INTERVAL_MS, 3000L);
168168
conf.set(RssSparkConfig.RSS_CLIENT_ACCESS_RETRY_TIMES, 3);
@@ -178,7 +178,7 @@ public void testIncludeProperties() throws Exception {
178178
RssSparkConfig.RSS_ACCESS_ID
179179
.key()
180180
.substring(RssSparkConfig.SPARK_RSS_CONFIG_PREFIX.length()));
181-
int confInitKeyCount = conf.getAll().length;
181+
final int confInitKeyCount = conf.getAll().length;
182182
assertCreateRssShuffleManager(conf);
183183

184184
ArgumentCaptor<RssAccessClusterRequest> argumentCaptor =
@@ -205,7 +205,7 @@ public void testIncludeProperties() throws Exception {
205205

206206
@Test
207207
public void testExcludeProperties() throws Exception {
208-
CoordinatorClient mockClient = setupMockedRssShuffleUtils(SUCCESS);
208+
final CoordinatorClient mockClient = setupMockedRssShuffleUtils(SUCCESS);
209209
SparkConf conf = new SparkConf();
210210
conf.set(RssSparkConfig.RSS_CLIENT_ACCESS_RETRY_INTERVAL_MS, 3000L);
211211
conf.set(RssSparkConfig.RSS_CLIENT_ACCESS_RETRY_TIMES, 3);
@@ -221,7 +221,7 @@ public void testExcludeProperties() throws Exception {
221221
RssSparkConfig.RSS_ACCESS_ID
222222
.key()
223223
.substring(RssSparkConfig.SPARK_RSS_CONFIG_PREFIX.length()));
224-
int confInitKeyCount = conf.getAll().length;
224+
final int confInitKeyCount = conf.getAll().length;
225225
assertCreateRssShuffleManager(conf);
226226

227227
ArgumentCaptor<RssAccessClusterRequest> argumentCaptor =

0 commit comments

Comments
 (0)