Skip to content

Commit 9faeebc

Browse files
committed
align with master
1 parent 46c7e20 commit 9faeebc

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

client-spark/common/src/main/java/org/apache/uniffle/shuffle/ReassignExecutor.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,12 @@ private void reassignAndResendBlocks(Set<TrackingBlockStatus> blocks) {
367367
// clear the previous retry state of block
368368
removeBlockStatsFunction.accept(block);
369369
final ShuffleBlockInfo newBlock = block;
370-
newBlock.incrRetryCnt();
370+
// if the status code is null, it means the block is resent due to stale assignment, not
371+
// because of the block send failure. In this case, the retry count should not be increased;
372+
// otherwise it may cause unexpected fast failure.
373+
if (blockStatus.getStatusCode() != null) {
374+
newBlock.incrRetryCnt();
375+
}
371376
newBlock.reassignShuffleServers(Arrays.asList(replacement));
372377
resendCandidates.add(newBlock);
373378
}

0 commit comments

Comments
 (0)