chore: remove useless variable in ShiroAuthenticationService

Author: sh1nj1

zeppelin-server/src/main/java/org/apache/zeppelin/service/ShiroAuthenticationService.java

@@ -466,10 +466,8 @@ private List<String> getUserList(JdbcRealm obj, String searchText, int numUsersT
       ps = con.prepareStatement(userquery);
       ps.setString(1, "%" + searchText + "%");
       rs = ps.executeQuery();
-      int count = 0;
-      while (rs.next() && count < numUsersToFetch) {
-        userlist.add(rs.getString(1).trim());
-        count++;
+      while (rs.next() && userlist.size() < numUsersToFetch) {
+        userlist.add(rs.getString(1));
       }
     } catch (Exception e) {
       LOGGER.error("Error retrieving User list from JDBC Realm", e);

zeppelin-server/src/test/java/org/apache/zeppelin/service/ShiroAuthenticationServiceTest.java

@@ -75,11 +75,12 @@ void testGetMatchedUsersWithJdbcRealm() throws Exception {
     try (Connection conn = dataSource.getConnection(); Statement stmt = conn.createStatement()) {
       stmt.execute("CREATE TABLE users (username VARCHAR PRIMARY KEY, password VARCHAR)");
       stmt.execute("INSERT INTO users VALUES ('admin', '')");
+      stmt.execute("INSERT INTO users VALUES ('admin1', '')");
       stmt.execute("INSERT INTO users VALUES ('test', '')");
     }
 
     // when
-    List<String> users = shiroSecurityService.getMatchedUsers("adm", 10);
+    List<String> users = shiroSecurityService.getMatchedUsers("adm", 1);
 
     // then
     assertEquals(1, users.size());