Skip to content

Commit 8c3dab5

Browse files
committed
apply review
1 parent 5ded275 commit 8c3dab5

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

zeppelin-web-angular/e2e/tests/notebook/published/published-paragraph.spec.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,7 @@ test.describe('Published Paragraph', () => {
9999
});
100100
});
101101

102-
test('should display published paragraph component and preserve URL context after modal interaction', async ({
103-
page
104-
}) => {
102+
test('should allow running paragraph via confirmation modal in published mode', async ({ page }) => {
105103
const { noteId, paragraphId } = testNotebook;
106104

107105
// Given: Navigate to a specific paragraph's published URL
@@ -121,7 +119,7 @@ test.describe('Published Paragraph', () => {
121119

122120
// Then: Confirmation modal should appear for paragraph execution
123121
const modal = page.locator('.ant-modal');
124-
await expect(modal).toBeVisible({ timeout: 5000 });
122+
await expect(modal).toBeVisible({ timeout: 20000 });
125123

126124
// Handle the execution confirmation to complete the published mode setup
127125
const runModalButton = modal.locator('button:has-text("Run")');
@@ -136,15 +134,10 @@ test.describe('Published Paragraph', () => {
136134
const isPublishedMode = await page.evaluate(() => document.querySelector('zeppelin-publish-paragraph') !== null);
137135
expect(isPublishedMode).toBe(true);
138136

139-
// Verify only the specific paragraph is displayed, not the entire notebook
140-
const notebookContainer = page.locator('zeppelin-notebook');
141137
const paragraphContainer = page.locator('zeppelin-publish-paragraph');
142138

143139
// Published component should be present
144140
await expect(paragraphContainer).toBeAttached();
145-
// Full notebook editing interface should not be visible
146-
const isFullNotebookMode = await notebookContainer.isVisible().catch(() => false);
147-
expect(isFullNotebookMode).toBe(false);
148141
});
149142
});
150143

0 commit comments

Comments
 (0)