Skip to content

Commit 8f64998

Browse files
committed
fix broken tests
1 parent 54b3056 commit 8f64998

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

zeppelin-web-angular/e2e/models/base-page.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,5 @@ export class BasePage {
2323

2424
async waitForPageLoad(): Promise<void> {
2525
await this.page.waitForLoadState('domcontentloaded', { timeout: 15000 });
26-
await this.page.waitForLoadState('networkidle', { timeout: 30000 });
2726
}
2827
}

zeppelin-web-angular/e2e/tests/notebook/keyboard/notebook-keyboard-shortcuts.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,8 @@ test.describe.serial('Comprehensive Keyboard Shortcuts (ShortcutsMap)', () => {
208208
await keyboardPage.setCodeEditorContent('line1\nline2\nline3');
209209

210210
// Position cursor at beginning of first line
211-
await keyboardPage.pressKey('Control+Home');
211+
await keyboardPage.pressKey('Control+A');
212+
await keyboardPage.pressKey('ArrowLeft');
212213

213214
// When: User presses Control+N (should move cursor down one line)
214215
await keyboardPage.pressMoveCursorDown();

zeppelin-web-angular/e2e/utils.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -224,14 +224,6 @@ export async function waitForZeppelinReady(page: Page): Promise<void> {
224224
return;
225225
}
226226

227-
// Additional check: ensure we're not stuck on login page
228-
await page
229-
.waitForFunction(() => !window.location.href.includes('#/login'), { timeout: 10000 })
230-
.catch(() => {
231-
// If still on login page, this is expected - login will handle redirect
232-
console.log('Still on login page - this is normal if authentication is required');
233-
});
234-
235227
// Wait for Angular and Zeppelin to be ready with more robust checks
236228
await page.waitForFunction(
237229
() => {

0 commit comments

Comments
 (0)