Conversation
|
This branch name is not following the standards: feature/|bugfix/|release/|hotfix/|support/|releasing/|dependabot/ |
|
This branch name is not following the standards: feature/|bugfix/|release/|hotfix/|support/|releasing/|dependabot/ |
earayu
deleted the
1421-bug-collectionsummary-reconciler-infinite-loop-bug---incorrect-sql-condition
branch
|
This branch name is not following the standards: feature/|bugfix/|release/|hotfix/|support/|releasing/|dependabot/ |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on February 3
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| and_( | ||
| CollectionSummary.version != CollectionSummary.observed_version, | ||
| CollectionSummary.status != CollectionSummaryStatus.GENERATING, | ||
| CollectionSummary.status == CollectionSummaryStatus.PENDING, |
There was a problem hiding this comment.
Re-generation for completed/failed summaries silently ignored
High Severity
The new query restricts reconciliation to only summaries with status == PENDING, but when re-generation is triggered for an existing summary via trigger_collection_summary_generation(), the update_version() method only increments the version without resetting status to PENDING. This means summaries in COMPLETE or FAILED state with a version mismatch will never be picked up for reconciliation, silently breaking the re-generation flow.
2 participants
Note
Narrows collection summary reconciliation scope to avoid processing in-progress items.
CollectionSummaryReconciler._get_summaries_needing_reconciliationto requirestatus == PENDINGandversion != observed_version(replacing prior condition that merely excludedGENERATING)Written by Cursor Bugbot for commit ded8d9d. This will update automatically on new commits. Configure here.