Skip to content

Commit 37e00c5

Browse files
authored
chore: support parameters api for addons (#1521)
1 parent ffc277f commit 37e00c5

36 files changed

+437
-274
lines changed

addons/apecloud-postgresql/templates/_helpers.tpl

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,15 @@ apecloud-postgresql-14-configuration-{{ .Chart.Version }}
7575
{{/*
7676
Define apecloud postgresql 14 component config constraint name
7777
*/}}
78-
{{- define "apecloud-postgresql-14.configConstraint" -}}
79-
apecloud-postgresql-14-cc-{{ .Chart.Version }}
78+
{{- define "apecloud-postgresql-14.pdName" -}}
79+
apecloud-postgresql-14-pd
80+
{{- end -}}
81+
82+
{{/*
83+
Define apecloud postgresql 14 component config constraint name
84+
*/}}
85+
{{- define "apecloud-postgresql-14.pcrName" -}}
86+
apecloud-postgresql-14-pcr
8087
{{- end -}}
8188

8289
{{/*

addons/apecloud-postgresql/templates/cmpd-apepg.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ spec:
1212
configs:
1313
- name: postgresql-consensusset-configuration
1414
templateRef: {{ include "apecloud-postgresql-14.configurationTemplate" . }}
15-
constraintRef: {{ include "apecloud-postgresql-14.configConstraint" . }}
16-
keys:
17-
- postgresql.conf
1815
namespace: {{ .Release.Namespace }}
1916
volumeName: postgresql-config
2017
defaultMode: 0444

addons/apecloud-postgresql/templates/configconstraint.yaml renamed to addons/apecloud-postgresql/templates/paramsdef-14.yaml

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
1-
{{- $cc := .Files.Get "config/pg14-config-effect-scope.yaml" | fromYaml }}
2-
apiVersion: apps.kubeblocks.io/v1beta1
3-
kind: ConfigConstraint
1+
{{- $pd := .Files.Get "config/pg14-config-effect-scope.yaml" | fromYaml }}
2+
apiVersion: parameters.kubeblocks.io/v1alpha1
3+
kind: ParametersDefinition
44
metadata:
5-
name: {{ include "apecloud-postgresql-14.configConstraint" . }}
5+
name: {{ include "apecloud-postgresql-14.pdName" . }}
66
labels:
77
{{- include "apecloud-postgresql.labels" . | nindent 4 }}
88
annotations:
99
{{- include "apecloud-postgresql.annotations" . | nindent 4 }}
1010
spec:
11+
fileName: postgresql.conf
1112
reloadAction:
1213
shellTrigger:
1314
sync: true
@@ -34,24 +35,21 @@ spec:
3435
# example: ../../pkg/configuration/testdata/mysql_openapi.json
3536
cue: |-
3637
{{- .Files.Get "config/pg14-config-constraint.cue" | nindent 6 }}
37-
# configuration file format
38-
fileFormatConfig:
39-
format: properties
4038
4139
## require db instance restart
4240
## staticParameters
43-
{{- if hasKey $cc "staticParameters" }}
41+
{{- if hasKey $pd "staticParameters" }}
4442
staticParameters:
45-
{{- $params := get $cc "staticParameters" }}
43+
{{- $params := get $pd "staticParameters" }}
4644
{{- range $params }}
4745
- {{ . }}
4846
{{- end }}
4947
{{- end}}
5048

5149
## define immutable parameter list, this feature is not currently supported.
52-
{{- if hasKey $cc "immutableParameters" }}
50+
{{- if hasKey $pd "immutableParameters" }}
5351
immutableParameters:
54-
{{- $params := get $cc "immutableParameters" }}
52+
{{- $params := get $pd "immutableParameters" }}
5553
{{- range $params }}
5654
- {{ . }}
5755
{{- end }}
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
apiVersion: parameters.kubeblocks.io/v1alpha1
2+
kind: ParamConfigRenderer
3+
metadata:
4+
name: {{ include "apecloud-postgresql-14.pcrName" . }}
5+
labels:
6+
{{- include "apecloud-postgresql.labels" . | nindent 4 }}
7+
spec:
8+
componentDef: {{ include "apecloud-postgresql-14.cmpdName" . }}
9+
parametersDefs:
10+
- {{ include "apecloud-postgresql-14.pdName" . }}
11+
12+
configs:
13+
- name: postgresql.conf
14+
fileFormatConfig:
15+
format: properties

addons/mogdb/templates/_helpers.tpl

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,17 @@ mogdb-configuration-tpl
9494
{{- end -}}
9595

9696
{{/*
97-
Define mogdb config constraint name
97+
Define mogdb parameters definition name
9898
*/}}
99-
{{- define "mogdb.constraintTplName" -}}
100-
mogdb-cc
99+
{{- define "mogdb.pdName" -}}
100+
mogdb-pd
101+
{{- end -}}
102+
103+
{{/*
104+
Define mogdb parameter config rendered name
105+
*/}}
106+
{{- define "mogdb.pcrName" -}}
107+
mogdb-pcr
101108
{{- end -}}
102109

103110
{{/*

addons/mogdb/templates/cmpd.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ spec:
2323
configs:
2424
- name: mogdb-configuration
2525
templateRef: {{ include "mogdb.configTplName" . }}
26-
constraintRef: {{ include "mogdb.constraintTplName" . }}
27-
keys:
28-
- postgresql.conf
2926
namespace: {{ .Release.Namespace }}
3027
volumeName: mogdb-config
3128
defaultMode: 0777
Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
1-
{{- $cc := .Files.Get "config/mogdb-config-effect-scope.yaml" | fromYaml }}
2-
apiVersion: apps.kubeblocks.io/v1beta1
3-
kind: ConfigConstraint
1+
{{- $pd := .Files.Get "config/mogdb-config-effect-scope.yaml" | fromYaml }}
2+
apiVersion: parameters.kubeblocks.io/v1alpha1
3+
kind: ParametersDefinition
44
metadata:
5-
name: {{ include "mogdb.constraintTplName" . }}
5+
name: {{ include "mogdb.pdName" . }}
66
labels:
77
{{- include "mogdb.labels" . | nindent 4 }}
88
spec:
9+
fileName: postgresql.conf
910

1011
# ConfigurationSchema that impose restrictions on engine parameter's rule
1112
parametersSchema:
@@ -19,25 +20,19 @@ spec:
1920
2021
## require db instance restart
2122
## staticParameters
22-
{{- if hasKey $cc "staticParameters" }}
23+
{{- if hasKey $pd "staticParameters" }}
2324
staticParameters:
24-
{{- $params := get $cc "staticParameters" }}
25+
{{- $params := get $pd "staticParameters" }}
2526
{{- range $params }}
2627
- {{ . }}
2728
{{- end }}
2829
{{- end}}
2930

3031
## define immutable parameter list, this feature is not currently supported.
31-
{{- if hasKey $cc "immutableParameters" }}
32+
{{- if hasKey $pd "immutableParameters" }}
3233
immutableParameters:
33-
{{- $params := get $cc "immutableParameters" }}
34+
{{- $params := get $pd "immutableParameters" }}
3435
{{- range $params }}
3536
- {{ . }}
3637
{{- end }}
37-
{{- end}}
38-
39-
40-
41-
# configuration file format
42-
fileFormatConfig:
43-
format: properties
38+
{{- end}}

addons/mogdb/templates/pcr.yaml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
apiVersion: parameters.kubeblocks.io/v1alpha1
2+
kind: ParamConfigRenderer
3+
metadata:
4+
name: {{ include "mogdb.pcrName" . }}
5+
labels:
6+
{{- include "mogdb.labels" . | nindent 4 }}
7+
spec:
8+
componentDef: {{ include "mogdb.cmpdName" . }}
9+
parametersDefs:
10+
- {{ include "mogdb.pdName" . }}
11+
12+
configs:
13+
- name: postgresql.conf
14+
fileFormatConfig:
15+
format: properties

addons/oceanbase-ce/templates/_helpers.tpl

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,15 +93,18 @@ oceanbase-ce-{{ .Chart.Version }}
9393
^oceanbase-ce-
9494
{{- end -}}
9595

96-
{{- define "oceanbase-ce.cc.sysvars" -}}
96+
{{- define "oceanbase-ce.pdVarName" -}}
9797
oceanbase-ce-sysvars-cc
9898
{{- end -}}
9999

100100

101-
{{- define "oceanbase-ce.cc.parameters" -}}
101+
{{- define "oceanbase-ce.pdParamName" -}}
102102
oceanbase-ce-parameters-cc
103103
{{- end -}}
104104

105+
{{- define "oceanbase-ce.pcrName" -}}
106+
oceanbase-ce-pcr
107+
{{- end -}}
105108

106109
{{- define "oceanbase-ce.clusterDefinition" -}}
107110
oceanbase-ce
@@ -216,17 +219,13 @@ configs:
216219
- name: oceanbase-sysvars
217220
templateRef: {{ include "oceanbase-ce.cm.sysvars" .}}
218221
volumeName: oceanbase-sysvars
219-
constraintRef: {{ include "oceanbase-ce.cc.sysvars" .}}
220222
namespace: {{ .Release.Namespace }}
221223
defaultMode: 0555
222224
- name: oceanbase-config
223225
templateRef: {{ include "oceanbase-ce.cm.config" .}}
224226
volumeName: oceanbase-config
225-
constraintRef: {{ include "oceanbase-ce.cc.parameters" .}}
226227
namespace: {{ .Release.Namespace }}
227228
defaultMode: 0555
228-
reRenderResourceTypes:
229-
- vscale
230229
scripts:
231230
- name: oceanbase-scripts
232231
templateRef: {{ include "oceanbase-ce.scripts.bootscripts" .}}

addons/oceanbase-ce/templates/configconstraint.yaml

Lines changed: 0 additions & 135 deletions
This file was deleted.

0 commit comments

Comments
 (0)