Skip to content

Commit 9bb5bbe

Browse files
dongjiang1989wangyelei
authored andcommitted
feat: Change redis metrics to redis-exporter (#2345)
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
1 parent 008e83b commit 9bb5bbe

File tree

7 files changed

+17
-96
lines changed

7 files changed

+17
-96
lines changed

addons/redis/templates/_helpers.tpl

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -129,13 +129,6 @@ Define redis cluster component script template name
129129
redis-cluster-scripts-template-{{ .Chart.Version }}
130130
{{- end -}}
131131

132-
{{/*
133-
Define redis metrics config name
134-
*/}}
135-
{{- define "redis.metricsConfiguration" -}}
136-
redis-metrics-config
137-
{{- end -}}
138-
139132
{{- define "redis7.image" -}}
140133
{{ .Values.image.registry | default "docker.io" }}/{{ .Values.image.repository }}:{{ .Values.image.tag.major7.minor72 }}
141134
{{- end }}

addons/redis/templates/cmpd-redis-cluster.yaml

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,6 @@ spec:
8585
namespace: {{ $.Release.Namespace }}
8686
volumeName: redis-cluster-config
8787
externalManaged: true
88-
- name: redis-metrics-config
89-
template: {{ include "redis.metricsConfiguration" $ }}
90-
namespace: {{ $.Release.Namespace }}
91-
volumeName: redis-metrics-config
92-
defaultMode: 0444
9388
scripts:
9489
- name: redis-cluster-scripts
9590
template: {{ include "redisCluster.scriptsTemplate" $ }}
@@ -586,26 +581,20 @@ spec:
586581
runAsNonRoot: true
587582
runAsUser: 1001
588583
env:
589-
- name: ENDPOINT
590-
value: "localhost:$(SERVICE_PORT)"
591-
- name: METRICS_HTTP_PORT
592-
value: $(REDIS_METRICS_HTTP_PORT)
593-
- name: METRICS_SERVER_PORT
594-
value: $(REDIS_METRICS_SERVER_PORT)
584+
- name: REDIS_ADDR
585+
value: "redis://localhost:$(SERVICE_PORT)"
586+
- name: REDIS_EXPORTER_WEB_LISTEN_ADDRESS
587+
value: "0.0.0.0:$(REDIS_METRICS_HTTP_PORT)"
595588
- name: REDIS_USER
596589
value: $(REDIS_DEFAULT_USER)
597590
- name: REDIS_PASSWORD
598591
value: $(REDIS_DEFAULT_PASSWORD)
599-
command:
600-
- "/bin/agamotto"
601-
- "--config=/opt/conf/metrics-config.yaml"
592+
- name: REDIS_EXPORTER_IS_CLUSTER
593+
value: true
602594
ports:
603595
- name: http-metrics
604596
containerPort: {{ $.Values.metrics.service.port }}
605597
- name: server-metrics
606598
containerPort: {{ $.Values.metrics.service.serverPort }}
607-
volumeMounts:
608-
- name: redis-metrics-config
609-
mountPath: /opt/conf
610599
{{- end }}
611600
{{- end }}

addons/redis/templates/cmpd-redis.yaml

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,6 @@ spec:
8585
namespace: {{ $.Release.Namespace }}
8686
volumeName: redis-config
8787
externalManaged: true
88-
- name: redis-metrics-config
89-
template: {{ include "redis.metricsConfiguration" $ }}
90-
namespace: {{ $.Release.Namespace }}
91-
volumeName: redis-metrics-config
92-
defaultMode: 0444
9388
scripts:
9489
- name: redis-scripts
9590
template: {{ include "redis.scriptsTemplate" $ }}
@@ -495,26 +490,20 @@ spec:
495490
runAsNonRoot: true
496491
runAsUser: 1001
497492
env:
498-
- name: ENDPOINT
499-
value: "localhost:$(SERVICE_PORT)"
500-
- name: METRICS_HTTP_PORT
501-
value: $(REDIS_METRICS_HTTP_PORT)
502-
- name: METRICS_SERVER_PORT
503-
value: $(REDIS_METRICS_SERVER_PORT)
493+
- name: REDIS_ADDR
494+
value: "redis://localhost:$(SERVICE_PORT)"
495+
- name: REDIS_EXPORTER_WEB_LISTEN_ADDRESS
496+
value: "0.0.0.0:$(REDIS_METRICS_HTTP_PORT)"
504497
- name: REDIS_USER
505498
value: $(REDIS_DEFAULT_USER)
506499
- name: REDIS_PASSWORD
507500
value: $(REDIS_DEFAULT_PASSWORD)
508-
command:
509-
- "/bin/agamotto"
510-
- "--config=/opt/conf/metrics-config.yaml"
501+
- name: REDIS_EXPORTER_IS_CLUSTER
502+
value: false
511503
ports:
512504
- name: http-metrics
513505
containerPort: {{ $.Values.metrics.service.port }}
514506
- name: server-metrics
515507
containerPort: {{ $.Values.metrics.service.serverPort }}
516-
volumeMounts:
517-
- name: redis-metrics-config
518-
mountPath: /opt/conf
519508
{{- end }}
520509
{{- end }}

addons/redis/templates/cmpv-redis-cluster.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ spec:
3333
switchover: {{ $redisRepository }}:{{ .imageTag }}
3434
preTerminate: {{ $redisRepository }}:{{ .imageTag }}
3535
memberLeave: {{ $redisRepository }}:{{ .imageTag }}
36-
metrics: {{ include "metrics.repository" $ }}:0.1.2-beta.1
36+
metrics: {{ include "metrics.repository" $ }}:v1.80.1
3737
memberJoin: {{ $redisRepository }}:{{ .imageTag }}
3838
init-dbctl: {{ $.Values.dbctlImage.registry | default ( $.Values.image.registry | default "docker.io" ) }}/{{ $.Values.dbctlImage.repository }}:{{ $.Values.dbctlImage.tag }}
3939
{{- end }}

addons/redis/templates/cmpv-redis.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ spec:
2828
serviceVersion: {{ .version }}
2929
images:
3030
redis: {{ $redisRepository }}:{{ .imageTag }}
31-
metrics: {{ include "metrics.repository" $ }}:0.1.2-beta.1
31+
metrics: {{ include "metrics.repository" $ }}:v1.80.1
3232
init-dbctl: {{ $.Values.dbctlImage.registry | default ( $.Values.image.registry | default "docker.io" ) }}/{{ $.Values.dbctlImage.repository }}:{{ $.Values.dbctlImage.tag }}
3333
postProvision: {{ $redisRepository }}:{{ .imageTag }}
3434
accountProvision: {{ $redisRepository }}:{{ .imageTag }}

addons/redis/templates/metrics-configmap.yaml

Lines changed: 0 additions & 51 deletions
This file was deleted.

addons/redis/values.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,9 @@ metrics:
150150
image:
151151
# if the value of metrics.image.registry is not specified using `--set`, it will be set to the value of 'image.registry' by default
152152
registry: ""
153-
repository: apecloud/agamotto
154-
tag: 0.1.2-beta.1
153+
# Supports Valkey and Redis 2.x, 3.x, 4.x, 5.x, 6.x, and 7.x
154+
repository: oliver006/redis_exporter
155+
tag: v1.80.1
155156
pullPolicy: IfNotPresent
156157
service:
157158
port: 9121

0 commit comments

Comments
 (0)