Skip to content

Conversation

@cjc7373
Copy link
Contributor

@cjc7373 cjc7373 commented Jan 29, 2026

  • bump golangci-lint to v2
  • remove staticcheck, since it is included in golangci-lint

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Jan 29, 2026
@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

@cjc7373 cjc7373 added the nopick Not auto cherry-pick when PR merged label Jan 29, 2026
it's covered by golangci-lint
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.61%. Comparing base (804edc4) to head (d45101e).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/instance/reconciler_update.go 0.00% 3 Missing ⚠️
pkg/operations/backup.go 0.00% 3 Missing ⚠️
controllers/trace/reconciler_tree.go 66.66% 1 Missing ⚠️
pkg/kbagent/util/event.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10033      +/-   ##
==========================================
+ Coverage   51.37%   51.61%   +0.24%     
==========================================
  Files         541      544       +3     
  Lines       58774    59433     +659     
==========================================
+ Hits        30194    30679     +485     
- Misses      25627    25761     +134     
- Partials     2953     2993      +40     
Flag Coverage Δ
unittests 51.61% <50.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cjc7373 cjc7373 marked this pull request as ready for review January 29, 2026 08:10
@cjc7373 cjc7373 requested review from a team, JashBook and ahjing99 as code owners January 29, 2026 08:10
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 29, 2026
@cjc7373 cjc7373 added pick-1.1 Auto cherry-pick to release-1.1 when PR merged and removed nopick Not auto cherry-pick when PR merged labels Jan 29, 2026
@cjc7373 cjc7373 merged commit 7f42f84 into main Jan 29, 2026
64 of 66 checks passed
@cjc7373 cjc7373 deleted the support/lint-upgrade branch January 29, 2026 09:19
@github-actions github-actions bot added this to the Release 1.2.0 milestone Jan 29, 2026
@apecloud-bot
Copy link
Collaborator

/cherry-pick release-1.1

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/21472491632

apecloud-bot pushed a commit that referenced this pull request Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test pick-1.1 Auto cherry-pick to release-1.1 when PR merged size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants