fix: don't ignore not found error in its controller #9823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Auto Cherry-pick Instructions |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9823 +/- ##
==========================================
+ Coverage 50.86% 52.59% +1.73%
==========================================
Files 542 544 +2
Lines 58771 60967 +2196
==========================================
+ Hits 29895 32067 +2172
+ Misses 25927 25905 -22
- Partials 2949 2995 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
size/S
leon-inf
reviewed
Oct 22, 2025
leon-inf
reviewed
Oct 23, 2025
Contributor
leon-inf
left a comment
leon-inf
left a comment
There was a problem hiding this comment.
Errors from status calls should also be wrapped to maintain consistency.
Contributor
Author
|
The review comments above are addressed. @leon-inf PTAL |
leon-inf
approved these changes
Dec 31, 2025
wangyelei
approved these changes
Dec 31, 2025
Collaborator
|
/cherry-pick release-1.0 |
Collaborator
|
🤖 says: cherry pick action finished successfully 🎉! |
apecloud-bot
pushed a commit
that referenced
this pull request
Dec 31, 2025
(cherry picked from commit 668922f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When kb enables IN_PLACE_POD_VERTICAL_SCALING feature gate, but k8s does not, a vscale operation may fail in its because kube-apiserver does not have the "resize" subresource. ITS controller should error emit a warning event like:
But instead, its controller silently ignores this error and makes the reconcilation successful.