subpath should use sub.Config().Name, not .Path.

apenwarr · apenwarr · commit 58c18b173d2c · 2019-11-26T22:10:46.000-05:00
The git config for submodules is pretty confusing. .Name corresponds to
the path of the module's gitdir under .git/modules, while .Path
corresponds to the path of the module's worktree relative to the
parent. We want the former.
diff --git a/subtrac.go b/subtrac.go
@@ -388,7 +388,7 @@ func (c *Cache) allSubrepos() (paths []string, repos []*git.Repository, err erro
 			if subpath != "" {
 				subpath += "/modules/"
 			}
-			subpath += sub.Config().Path
+			subpath += sub.Config().Name
 
 			ss, err := sub.Status()
 			if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -388,7 +388,7 @@ func (c Cache) allSubrepos() (paths []string, repos []git.Repository, err erro`
`388`	`388`	`if subpath != "" {`
`389`	`389`	`subpath += "/modules/"`
`390`	`390`	`}`
`391`		`- subpath += sub.Config().Path`
	`391`	`+ subpath += sub.Config().Name`
`392`	`392`
`393`	`393`	`ss, err := sub.Status()`
`394`	`394`	`if err != nil {`