Skip to content

Commit d229467

Browse files
spenaprniwa
authored andcommitted
Clarify how to get patches landed when not a committer
Suggest using request-merge-queue when discussing other merge-queue labels.
1 parent b113b05 commit d229467

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

docs/Deep Dive/GitHub/PullRequests.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,4 +36,4 @@ Only repository administrators have direct commit access, and this is reserved f
3636

3737
Each queue makes sure a change is reviewed by adding the name of all [reviewers](https://webkit.org/team/#reviewers) who have approved a pull request to the commit message. It will then check the commit message for `Reviewed by`.
3838

39-
Note that the Merge-Queues will reject pull requests labeled by contributors who are not [committers](https://webkit.org/team/#committers).
39+
Note that the Merge-Queues will reject pull requests labeled by contributors who are not [committers](https://webkit.org/team/#committers). Non-committers can use the [`request-merge-queue`](https://github.com/WebKit/WebKit/labels?q=request-merge-queue) label to get reviewers to add the change to the queue.

docs/Getting Started/ContributingCode.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ git webkit pr
5656

5757
### Merge Queues
5858

59-
To land a pull request, add the [`safe-merge-queue`](https://github.com/WebKit/WebKit/labels?q=safe-merge-queue), [`merge-queue`](https://github.com/WebKit/WebKit/labels?q=merge-queue), or [`unsafe-merge-queue`](https://github.com/WebKit/WebKit/labels?q=unsafe-merge-queue) label to your pull request. These labels will put your pull request into [Safe-Merge-Queue](https://ews-build.webkit.org/#/builders/Safe-Merge-Queue), [Merge-Queue](https://ews-build.webkit.org/#/builders/Merge-Queue), and [Unsafe-Merge-Queue](https://ews-build.webkit.org/#/builders/Unsafe-Merge-Queue), respectively, which will commit your pull request to the WebKit repository.
59+
If you have [committer](https://webkit.org/team/#committers) rights, you can land a pull request by adding the [`safe-merge-queue`](https://github.com/WebKit/WebKit/labels?q=safe-merge-queue), [`merge-queue`](https://github.com/WebKit/WebKit/labels?q=merge-queue), or [`unsafe-merge-queue`](https://github.com/WebKit/WebKit/labels?q=unsafe-merge-queue) label to your pull request. These labels will put your pull request into [Safe-Merge-Queue](https://ews-build.webkit.org/#/builders/Safe-Merge-Queue), [Merge-Queue](https://ews-build.webkit.org/#/builders/Merge-Queue), and [Unsafe-Merge-Queue](https://ews-build.webkit.org/#/builders/Unsafe-Merge-Queue), respectively, which will commit your pull request to the WebKit repository. If you are not a committer, you can use [`request-merge-queue`](https://github.com/WebKit/WebKit/labels?q=request-merge-queue) so whoever reviews the patch can add it to the queue.
6060

6161
Each queue runs a style-check and inserts reviewer information into the commit message and modified change logs. They check that a pull request has been reviewed by checking the commit message before landing the change.
6262

0 commit comments

Comments
 (0)