Skip to content

Commit ceb5988

Browse files
author
Spencer Dellis
authored
Resolve reactive props animation issue.
A small consequence of replacing the entire dataset in the mixins files is that it causes certain charts to completely re-render even if only the 'data' attribute of a dataset is changing. In my case, I set up a reactive doughnut chart with two data points but whenever the data values change, instead of shifting the fill coloring, it completely re-renders the entire chart. You can see the issue in this fiddle (note the constant re-rendering): https://jsfiddle.net/sg0c82ev/11/ To solve the issue, I instead run a diff between the new and old dataset keys, remove keys that aren't present in the new data, and update the rest of the attributes individually. After making these changes my doughnut chart is animating as expected (even when adding and removing new dataset attributes). A fiddle with my changes: https://jsfiddle.net/sg0c82ev/12/ Perhaps this is too specific of a scenario to warrant a complexity increase like this (and better suited for a custom watcher) but I figured it would be better to dump it here and make it available for review. Let me know what you think.
1 parent d60c63e commit ceb5988

File tree

1 file changed

+20
-1
lines changed

1 file changed

+20
-1
lines changed

src/mixins/reactiveProp.js

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,26 @@ module.exports = {
2727
// Check if Labels are equal and if dataset length is equal
2828
if (newLabels === oldLabels && oldData.datasets.length === newData.datasets.length) {
2929
newData.datasets.forEach((dataset, i) => {
30-
chart.data.datasets[i] = dataset
30+
// Get new and old dataset keys
31+
const oldDatasetKeys = Object.keys(oldData.datasets[i])
32+
const newDatasetKeys = Object.keys(dataset)
33+
34+
// Get keys that aren't present in the new data
35+
const deletionKeys = oldDatasetKeys.filter((key) => {
36+
return key !== '_meta' && newDatasetKeys.indexOf(key) === -1
37+
})
38+
39+
// Remove outdated key-value pairs
40+
deletionKeys.forEach((deletionKey) => {
41+
delete chart.data.datasets[i][deletionKey]
42+
})
43+
44+
// Update attributes individually to avoid re-rendering the entire chart
45+
for (const attribute in dataset) {
46+
if (dataset.hasOwnProperty(attribute)) {
47+
chart.data.datasets[i][attribute] = dataset[attribute]
48+
}
49+
}
3150
})
3251

3352
chart.data.labels = newData.labels

0 commit comments

Comments
 (0)