Removed with sharing from selectors

The calling context determines this by default, e.g. the service layer,
if the selector class requires ‘without sharing’ escalation it can do
this within the selector method implementation via a private inner
class.

Author: afawcettffdc

fflib-sample-code/src/classes/AccountsSelector.cls

@@ -27,7 +27,7 @@
 /**
  * This is a basic selector for Account for this app, note how it implements selectByOpportunity
  **/
-public with sharing class AccountsSelector extends fflib_SObjectSelector
+public class AccountsSelector extends fflib_SObjectSelector
 	implements IAccountsSelector
 {
 	public static IAccountsSelector newInstance()

fflib-sample-code/src/classes/OpportunitiesSelector.cls

@@ -24,7 +24,7 @@
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 **/
 
-public with sharing class OpportunitiesSelector extends fflib_SObjectSelector
+public class OpportunitiesSelector extends fflib_SObjectSelector
 	implements IOpportunitiesSelector
 {
 	public static IOpportunitiesSelector newInstance()

fflib-sample-code/src/classes/OpportunityLineItemsSelector.cls

@@ -24,7 +24,7 @@
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 **/
 
-public with sharing class OpportunityLineItemsSelector extends fflib_SObjectSelector
+public class OpportunityLineItemsSelector extends fflib_SObjectSelector
 {
 	public List<Schema.SObjectField> getSObjectFieldList()
 	{

fflib-sample-code/src/classes/PricebookEntriesSelector.cls

@@ -24,7 +24,7 @@
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 **/
 
-public with sharing class PricebookEntriesSelector extends fflib_SObjectSelector
+public class PricebookEntriesSelector extends fflib_SObjectSelector
 {
 	public List<Schema.SObjectField> getSObjectFieldList()
 	{

fflib-sample-code/src/classes/PricebooksSelector.cls

@@ -24,7 +24,7 @@
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 **/
 
-public with sharing class PricebooksSelector extends fflib_SObjectSelector
+public class PricebooksSelector extends fflib_SObjectSelector
 {
 	public List<Schema.SObjectField> getSObjectFieldList()
 	{

fflib-sample-code/src/classes/ProductsSelector.cls

@@ -24,7 +24,7 @@
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 **/
 
-public with sharing class ProductsSelector extends fflib_SObjectSelector
+public class ProductsSelector extends fflib_SObjectSelector
 {
 	public ProductsSelector()
 	{

fflib-sample-code/src/classes/ProductsSelectorTest.cls

@@ -25,7 +25,7 @@
 **/
 
 @IsTest
-private with sharing class ProductsSelectorTest 
+private class ProductsSelectorTest 
 {
 	@IsTest
 	private static void testSelectById()