switched reference to "Records" (which implies a class when considering the variable name is captilized) to "this.records"

Author: John M. Daniel

sfdx-source/apex-common-samplecode/main/classes/domains/AbstractChargeable.cls

@@ -54,7 +54,7 @@ public with sharing abstract class AbstractChargeable extends fflib_SObjectDomai
 
 		Integer hoursWorkedRecordIdx = 0; 
 
-		for(SObject record : Records)
+		for(SObject record : this.records)
 		{
 			record.put(costOfHoursWorkedField, hoursWorked[hoursWorkedRecordIdx++] * 100);	
 		}

sfdx-source/apex-common-samplecode/main/classes/domains/DeveloperWorkItems.cls

@@ -52,7 +52,7 @@ public with sharing class DeveloperWorkItems extends AbstractChargeable
 	{
 		// Calculate the hours worked for each record
 		List<Integer> hoursWorked = new List<Integer>(); 
-		for(DeveloperWorkItem__c workItem : (List<DeveloperWorkItem__c>) Records)
+		for(DeveloperWorkItem__c workItem : (List<DeveloperWorkItem__c>) this.records)
 		{
 			// This calculation is intentionally simplistic for illustration purposes
 			hoursWorked.add((Integer)  

sfdx-source/apex-common-samplecode/main/classes/domains/Opportunities.cls

@@ -46,7 +46,7 @@ public class Opportunities extends fflib_SObjectDomain
 	public void generate(InvoicingService.InvoiceFactory invoiceFactory)
 	{
 		// Utilise InvoiceFactory to create invoices from Opportunity details
-		for(Opportunity opportunity : (List<Opportunity>) Records)
+		for(Opportunity opportunity : (List<Opportunity>) this.records)
 		{
 			InvoicingService.Invoice invoice = new InvoicingService.Invoice();
 			invoice.Account = opportunity.AccountId;
@@ -69,7 +69,7 @@ public class Opportunities extends fflib_SObjectDomain
 	public override void onApplyDefaults()
 	{
 		// Apply defaults to Opportunities
-		for(Opportunity opportunity : (List<Opportunity>) Records)
+		for(Opportunity opportunity : (List<Opportunity>) this.records)
 		{
 			opportunity.DiscountType__c = OpportunitySettings__c.getInstance().DiscountType__c;						
 		}
@@ -78,7 +78,7 @@ public class Opportunities extends fflib_SObjectDomain
 	public override void onValidate()	
 	{
 		// Validate Opportunities
-		for(Opportunity opp : (List<Opportunity>) Records)
+		for(Opportunity opp : (List<Opportunity>) this.records)
 		{
 			if(opp.Type!=null && opp.Type.startsWith('Existing') && opp.AccountId == null)
 			{
@@ -90,7 +90,7 @@ public class Opportunities extends fflib_SObjectDomain
 	public override void onValidate(Map<Id,SObject> existingRecords)
 	{
 		// Validate changes to Opportunities
-		for(Opportunity opp : (List<Opportunity>) Records)
+		for(Opportunity opp : (List<Opportunity>) this.records)
 		{
 			Opportunity existingOpp = (Opportunity) existingRecords.get(opp.Id);
 			if(opp.Type != existingOpp.Type)
@@ -124,7 +124,7 @@ public class Opportunities extends fflib_SObjectDomain
 		List<OpportunityLineItem> linesToApplyDiscount = new List<OpportunityLineItem>();
 
 		// Apply discount 
-		for(Opportunity opportunity : (List<Opportunity>) Records)
+		for(Opportunity opportunity : (List<Opportunity>) this.records)
 		{
 			// Appply to the Opporunity Amount?
 			if(opportunity.OpportunityLineItems == null || 

sfdx-source/apex-common-samplecode/main/classes/domains/OpportunityLineItems.cls

@@ -52,7 +52,7 @@ public with sharing class OpportunityLineItems extends fflib_SObjectDomain
 		Decimal factor = Opportunities.calculateDiscountFactor(discountPercentage);
 
 		// Adjust UnitPrice of each line according to Discount Type of Opportunity
-		for(OpportunityLineItem line : (List<OpportunityLineItem>) Records)
+		for(OpportunityLineItem line : (List<OpportunityLineItem>) this.records)
 		{
 			// Skip products that have not been approved for discounting
 			Opportunity opportunity = opportunitiesById.get(line.OpportunityId);