fix: replace type casting with method

Cristian N · Cristian N · commit 455fbd307bd1 · 2024-09-06T14:11:58.000+02:00
diff --git a/sfdx-source/apex-common/main/classes/fflib_SObjects.cls b/sfdx-source/apex-common/main/classes/fflib_SObjects.cls
@@ -182,7 +182,7 @@ public virtual class fflib_SObjects
 		Set<String> result = new Set<String>();
 		for (SObject record : getRecords())
 		{
-			result.add((String) record.get(field));
+			result.add(String.valueOf(record.get(field)));
 		}
 		return result;
 	}
@@ -257,7 +257,7 @@ public virtual class fflib_SObjects
 		{
 			for (SObjectField field : fields)
 			{
-				if (String.isNotBlank((String) record.get(field))) continue;
+				if (String.isNotBlank(String.valueOf(record.get(field)))) continue;
 
 				result.add(record);
 				break;
@@ -279,7 +279,7 @@ public virtual class fflib_SObjects
 			Boolean allBlank = true;
 			for (SObjectField field : fields)
 			{
-				if (String.isNotBlank((String) record.get(field)))
+				if (String.isNotBlank(String.valueOf(record.get(field))))
 				{
 					allBlank = false;
 					break;
@@ -314,7 +314,7 @@ public virtual class fflib_SObjects
 		{
 			for (SObjectField field : fields)
 			{
-				if (String.isNotBlank((String) record.get(field)))
+				if (String.isNotBlank(String.valueOf(record.get(field))))
 				{
 					result.add(record);
 					break;
@@ -337,7 +337,7 @@ public virtual class fflib_SObjects
 			Boolean allNonBlank = true;
 			for (SObjectField field : fields)
 			{
-				if (String.isBlank((String) record.get(field)))
+				if (String.isBlank(String.valueOf(record.get(field))))
 				{
 					allNonBlank = false;
 					break;

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ public virtual class fflib_SObjects`
`182`	`182`	`Set<String> result = new Set<String>();`
`183`	`183`	`for (SObject record : getRecords())`
`184`	`184`	`{`
`185`		`- result.add((String) record.get(field));`
	`185`	`+ result.add(String.valueOf(record.get(field)));`
`186`	`186`	`}`
`187`	`187`	`return result;`
`188`	`188`	`}`
`@@ -257,7 +257,7 @@ public virtual class fflib_SObjects`
`257`	`257`	`{`
`258`	`258`	`for (SObjectField field : fields)`
`259`	`259`	`{`
`260`		`- if (String.isNotBlank((String) record.get(field))) continue;`
	`260`	`+ if (String.isNotBlank(String.valueOf(record.get(field)))) continue;`
`261`	`261`
`262`	`262`	`result.add(record);`
`263`	`263`	`break;`
`@@ -279,7 +279,7 @@ public virtual class fflib_SObjects`
`279`	`279`	`Boolean allBlank = true;`
`280`	`280`	`for (SObjectField field : fields)`
`281`	`281`	`{`
`282`		`- if (String.isNotBlank((String) record.get(field)))`
	`282`	`+ if (String.isNotBlank(String.valueOf(record.get(field))))`
`283`	`283`	`{`
`284`	`284`	`allBlank = false;`
`285`	`285`	`break;`
`@@ -314,7 +314,7 @@ public virtual class fflib_SObjects`
`314`	`314`	`{`
`315`	`315`	`for (SObjectField field : fields)`
`316`	`316`	`{`
`317`		`- if (String.isNotBlank((String) record.get(field)))`
	`317`	`+ if (String.isNotBlank(String.valueOf(record.get(field))))`
`318`	`318`	`{`
`319`	`319`	`result.add(record);`
`320`	`320`	`break;`
`@@ -337,7 +337,7 @@ public virtual class fflib_SObjects`
`337`	`337`	`Boolean allNonBlank = true;`
`338`	`338`	`for (SObjectField field : fields)`
`339`	`339`	`{`
`340`		`- if (String.isBlank((String) record.get(field)))`
	`340`	`+ if (String.isBlank(String.valueOf(record.get(field))))`
`341`	`341`	`{`
`342`	`342`	`allNonBlank = false;`
`343`	`343`	`break;`