NonReferenceFieldException throw when external object referencing a parent field via indirect lookup on a custom object.

cdelfattore · cdelfattore · commit 5ae96f3e1f42 · 2024-10-29T12:11:59.000-04:00
diff --git a/sfdx-source/apex-common/main/classes/fflib_QueryFactory.cls b/sfdx-source/apex-common/main/classes/fflib_QueryFactory.cls
@@ -123,7 +123,8 @@ public class fflib_QueryFactory { //No explicit sharing declaration - inherit fr
 				fflib_SecurityUtils.checkFieldIsReadable(lastSObjectType, token);
 			}
 
-			if (token != null && i.hasNext() && tokenDescribe.getSoapType() == Schema.SoapType.ID) {
+			if (token != null && i.hasNext() && (tokenDescribe.getSoapType() == Schema.SoapType.ID
+				|| (tokenDescribe.getSoapType() == Schema.SoapType.STRING && tokenDescribe.getType() == Schema.DisplayType.REFERENCE))) {
 				List<Schema.sObjectType> relatedObjs = tokenDescribe.getReferenceTo(); //if it's polymorphic, it matters which one we use - i.e. Lead.Owner is GROUP|USER and each has different fields.
 
 				if (relatedObjs.size() == 1 || relatedSObjectType == null) {

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,8 @@ public class fflib_QueryFactory { //No explicit sharing declaration - inherit fr`
`123`	`123`	`fflib_SecurityUtils.checkFieldIsReadable(lastSObjectType, token);`
`124`	`124`	`}`
`125`	`125`
`126`		`- if (token != null && i.hasNext() && tokenDescribe.getSoapType() == Schema.SoapType.ID) {`
	`126`	`+ if (token != null && i.hasNext() && (tokenDescribe.getSoapType() == Schema.SoapType.ID`
	`127`	`+ \|\| (tokenDescribe.getSoapType() == Schema.SoapType.STRING && tokenDescribe.getType() == Schema.DisplayType.REFERENCE))) {`
`127`	`128`	`List<Schema.sObjectType> relatedObjs = tokenDescribe.getReferenceTo(); //if it's polymorphic, it matters which one we use - i.e. Lead.Owner is GROUP\|USER and each has different fields.`
`128`	`129`
`129`	`130`	`if (relatedObjs.size() == 1 \|\| relatedSObjectType == null) {`