Merge pull request #398 from scottmcclung:feature/security-utils-test-fix

fflib_SecurityUtilsTest: Applying permission set to Read Only profile user

Author: ImJohnMDaniel

sfdx-source/apex-common/test/classes/fflib_SecurityUtilsTest.cls

@@ -80,16 +80,16 @@ private class fflib_SecurityUtilsTest {
 
 	static User setupTestUser(String profileName){
 		Profile p;
-		Boolean usedMinimumAccessProfile = false;
+		Boolean applyReadOnlyPermissionSet = false;
 		if (profileName == 'Read Only') {
+			applyReadOnlyPermissionSet = true;
 			try {
 				p = getProfile(profileName);
 			} catch (QueryException ex) {
 				if (ex.getMessage().contains('List has no rows for assignment to SObject')) {
 					// #315 If the "Read Only" Profile is absent, then assume it's a Spring '21 org and see if there's a
 					// "Minimum Access - Salesforce" Profile we can use instead.
 					p = getProfile('Minimum Access - Salesforce');
-					usedMinimumAccessProfile = true;
 				}
 			}
 		} else {
@@ -117,7 +117,7 @@ private class fflib_SecurityUtilsTest {
 		);
 		insert usr;
 
-		if (usedMinimumAccessProfile) {
+		if (applyReadOnlyPermissionSet) {
 			// #315 We need to assign the Perm Set to grant Account "Read" access
 			PermissionSet accountReadPS = [SELECT Id FROM PermissionSet WHERE Name = 'ReadOnlyPermissionSet'];
 			PermissionSetAssignment psa = new PermissionSetAssignment(AssigneeId = usr.Id, PermissionSetId = accountReadPS.Id);