Merge pull request #349 from aepsf/change-SObjects

Change Line 226 to isNotBlank in fflib_SObjects.cls

Author: daveespo

sfdx-source/apex-common/main/classes/fflib_SObjects.cls

@@ -223,7 +223,7 @@ public virtual class fflib_SObjects
 		{
 			for (SObjectField sObjectField : sObjectFields)
 			{
-				if (String.isBlank((String) record.get(sObjectField)))
+				if (String.isNotBlank((String) record.get(sObjectField)))
 				{
 					result.add(record);
 					break;

sfdx-source/apex-common/test/classes/fflib_SObjectsTest.cls

@@ -74,15 +74,15 @@ private class fflib_SObjectsTest
 	{
 		DomainAccounts domain = generateDomain();
 
-		System.assert(domain.selectWithShippingCountry().size() == 3);
+		System.assert(domain.selectWithShippingCountry().size() == 4);
 	}
 
 	@IsTest
 	static void itShouldReturnRecordsWithAllFieldValues()
 	{
 		DomainAccounts domain = generateDomain();
 
-		System.assert(domain.selectPopulatedRecords().size() == 3);
+		System.assert(domain.selectPopulatedRecords().size() == 4);
 	}
 
 	@IsTest
@@ -92,7 +92,7 @@ private class fflib_SObjectsTest
 		String country = 'Holland';
 		domain.setShippingCountry(country);
 
-		System.assert(domain.selectByShippingCountry(country).size() == 6);
+		System.assert(domain.selectByShippingCountry(country).size() == 7);
 	}
 
 
@@ -135,7 +135,8 @@ private class fflib_SObjectsTest
 						new Account(Name = 'C', ShippingCountry = 'UK'),
 						new Account(Name = 'D', ShippingCountry = ''),
 						new Account(Name = 'E'),
-						new Account()
+						new Account(),
+						new Account(Name = 'G', ShippingCountry = 'Canada')
 				}
 		);
 		return domain;