Skip to content

Commit cda8c10

Browse files
committed
adjustments based on feedback
1 parent 3f1d3c5 commit cda8c10

File tree

1 file changed

+16
-15
lines changed

1 file changed

+16
-15
lines changed

.github/workflows/deploy.and.test.yml

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,23 +19,24 @@ jobs:
1919
uses: apex-enterprise-patterns/setup-sfdx@v2 #We're using a fork of https://github.com/sfdx-actions/setup-sfdx for safety
2020
with:
2121
sfdx-auth-url: ${{ secrets.DEVHUB_SFDXURL }}
22-
# Install the required plugins
23-
- run: echo y | sf plugins install shane-sfdx-plugins
24-
# Setup the config parameters needed
25-
- run: sf config set target-dev-hub SFDX-ENV --global #Even though the setup-sfdx action uses --setdefaultdevhubusername, it doesn't seem to stick since it uses --setdefaultusername so we brute force it here
26-
# Create the scratch org
27-
- run: sf org create scratch --definition-file config/project-scratch-def.json --set-default --duration-days 1 --no-track-source
28-
# Install required dependency frameworks
29-
- run: sf shane github src install --convert --githubuser apex-enterprise-patterns --repo fflib-apex-mocks --path sfdx-source/apex-mocks
30-
# Deploy/compile the codebase
31-
- run: sf project deploy start
32-
# Run the core framework tests
33-
- run: sf apex run test --wait 5
22+
- name: Install the required plugins
23+
run: echo y | sf plugins install shane-sfdx-plugins
24+
- name: Setup the config parameters needed
25+
run: sf config set target-dev-hub SFDX-ENV --global #Even though the setup-sfdx action uses --setdefaultdevhubusername, it doesn't seem to stick since it uses --setdefaultusername so we brute force it here
26+
- name: Create the scratch org
27+
run: sf org create scratch --definition-file config/project-scratch-def.json --set-default --duration-days 1 --no-track-source
28+
- name: Install required dependency frameworks
29+
run: sf shane github src install --convert --githubuser apex-enterprise-patterns --repo fflib-apex-mocks --path sfdx-source/apex-mocks
30+
- name: Deploy and compile the codebase
31+
run: sf project deploy start
32+
- name: Run the core framework tests
33+
run: sf apex run test --wait 5
3434
# Intentionally install the Sample Code after the core AEP Commons test pass succeeds so that we don't deploy anything in Sample Code
3535
# that could mask a test failure. A much more involved solution would've been to do a workflow_dispatch to the samplecode project.
36-
- run: sf shane github src install --convert --githubuser apex-enterprise-patterns --repo fflib-apex-common-samplecode --path sfdx-source/apex-common-samplecode
37-
# Run the core framework tests and the sample code project tests
38-
- run: sf apex run test --wait 5
36+
- name: Install sample code project to verify with
37+
run: sf shane github src install --convert --githubuser apex-enterprise-patterns --repo fflib-apex-common-samplecode --path sfdx-source/apex-common-samplecode
38+
- name: Run the core framework tests and the sample code project tests
39+
run: sf apex run test --wait 5
3940
- name: Destroy scratch org
4041
run: sf org delete scratch --no-prompt
4142
if: always()

0 commit comments

Comments
 (0)