Upgraded k8s (#189)

* Upgraded k8s

* Fixed database to fail if it could not be created (caused by race condition during k8s upgrades and Pulumi thinking the database exists)

* Updated to latest k8s version

* Updated to latest 1.34 k8s version

Author: davidbyoung

infrastructure/pulumi/Pulumi.yaml

@@ -10,7 +10,7 @@ config:
     value:
       name: aphiria-com-cluster
       region: nyc3
-      version: 1.34.1-do.4
+      version: 1.34.5-do.0
       autoUpgrade: true
       surgeUpgrade: false
       ha: false

infrastructure/pulumi/src/components/db-creation.ts

@@ -105,7 +105,14 @@ export function createDatabaseCreationJob(args: DatabaseCreationJobArgs): k8s.ba
                                 command: [
                                     "sh",
                                     "-c",
-                                    `psql -c "CREATE DATABASE ${args.databaseName};" || echo "Database already exists (this is normal on re-runs)"`,
+                                    [
+                                        `output=$(psql -c "CREATE DATABASE ${args.databaseName};" 2>&1)`,
+                                        "rc=$?",
+                                        'if [ $rc -eq 0 ]; then echo "Database created successfully"',
+                                        'elif echo "$output" | grep -q "already exists"; then echo "Database already exists (this is normal on re-runs)"',
+                                        'else echo "FATAL: Failed to create database: $output" >&2; exit 1',
+                                        "fi",
+                                    ].join("; "),
                                 ],
                                 resources: DEFAULT_RESOURCES,
                             },

infrastructure/pulumi/tests/components/db-creation.test.ts

@@ -74,6 +74,28 @@ describe("createDatabaseCreationJob", () => {
         expect(namespace).toBe("preview-pr-456");
     });
 
+    it("should use a command that only tolerates 'already exists' errors", async () => {
+        const job = createDatabaseCreationJob({
+            namespace: "preview-pr-123",
+            databaseName: "aphiria_pr_123",
+            dbHost: "db.default.svc.cluster.local",
+            dbAdminUser: pulumi.output("postgres"),
+            dbAdminPassword: pulumi.output("admin-password"),
+            provider: k8sProvider,
+        });
+
+        const spec = await promiseOf(job.spec);
+        const command = spec!.template.spec!.containers[0].command!;
+        const shellCommand = command[2] as string;
+
+        // Must capture psql output and exit code
+        expect(shellCommand).toContain('output=$(psql -c "CREATE DATABASE aphiria_pr_123;"');
+        // Must check for "already exists" specifically
+        expect(shellCommand).toContain('grep -q "already exists"');
+        // Must exit non-zero on unexpected errors
+        expect(shellCommand).toContain("exit 1");
+    });
+
     it("should merge custom labels with default labels", async () => {
         const job = createDatabaseCreationJob({
             namespace: "preview-pr-789",