Merge pull request #2713 from Nek-/patch-1

soyuka · web-flow · commit 06655443f5b0 · 2019-04-19T09:17:39.000+02:00
Fix error message in identifiers extractor
diff --git a/src/Api/IdentifiersExtractor.php b/src/Api/IdentifiersExtractor.php
@@ -42,7 +42,7 @@ public function __construct(PropertyNameCollectionFactoryInterface $propertyName
         $this->resourceClassResolver = $resourceClassResolver;
 
         if (null === $this->resourceClassResolver) {
-            @trigger_error(sprintf('Not injecting %s in the CachedIdentifiersExtractor might introduce cache issues with object identifiers.', ResourceClassResolverInterface::class), E_USER_DEPRECATED);
+            @trigger_error(sprintf('Not injecting %s in the IdentifiersExtractor might introduce cache issues with object identifiers.', ResourceClassResolverInterface::class), E_USER_DEPRECATED);
         }
     }
 
diff --git a/tests/Api/IdentifiersExtractorTest.php b/tests/Api/IdentifiersExtractorTest.php
@@ -185,7 +185,7 @@ private function getResourceClassResolver()
 
     /**
      * @group legacy
-     * @expectedDeprecation Not injecting ApiPlatform\Core\Api\ResourceClassResolverInterface in the CachedIdentifiersExtractor might introduce cache issues with object identifiers.
+     * @expectedDeprecation Not injecting ApiPlatform\Core\Api\ResourceClassResolverInterface in the IdentifiersExtractor might introduce cache issues with object identifiers.
      */
     public function testLegacyGetIdentifiersFromItem()
     {
diff --git a/tests/Bridge/Symfony/Routing/IriConverterTest.php b/tests/Bridge/Symfony/Routing/IriConverterTest.php
@@ -309,7 +309,7 @@ public function testNoIdentifiersException()
     /**
      * @group legacy
      * @expectedDeprecation Not injecting "ApiPlatform\Core\Api\IdentifiersExtractorInterface" is deprecated since API Platform 2.1 and will not be possible anymore in API Platform 3
-     * @expectedDeprecation Not injecting ApiPlatform\Core\Api\ResourceClassResolverInterface in the CachedIdentifiersExtractor might introduce cache issues with object identifiers.
+     * @expectedDeprecation Not injecting ApiPlatform\Core\Api\ResourceClassResolverInterface in the IdentifiersExtractor might introduce cache issues with object identifiers.
      */
     public function testLegacyConstructor()
     {

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public function __construct(PropertyNameCollectionFactoryInterface $propertyName`
`42`	`42`	`$this->resourceClassResolver = $resourceClassResolver;`
`43`	`43`
`44`	`44`	`if (null === $this->resourceClassResolver) {`
`45`		`- @trigger_error(sprintf('Not injecting %s in the CachedIdentifiersExtractor might introduce cache issues with object identifiers.', ResourceClassResolverInterface::class), E_USER_DEPRECATED);`
	`45`	`+ @trigger_error(sprintf('Not injecting %s in the IdentifiersExtractor might introduce cache issues with object identifiers.', ResourceClassResolverInterface::class), E_USER_DEPRECATED);`
`46`	`46`	`}`
`47`	`47`	`}`
`48`	`48`
Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ private function getResourceClassResolver()`
`185`	`185`
`186`	`186`	`/**`
`187`	`187`	`* @group legacy`
`188`		`- * @expectedDeprecation Not injecting ApiPlatform\Core\Api\ResourceClassResolverInterface in the CachedIdentifiersExtractor might introduce cache issues with object identifiers.`
	`188`	`+ * @expectedDeprecation Not injecting ApiPlatform\Core\Api\ResourceClassResolverInterface in the IdentifiersExtractor might introduce cache issues with object identifiers.`
`189`	`189`	`*/`
`190`	`190`	`public function testLegacyGetIdentifiersFromItem()`
`191`	`191`	`{`
Original file line number	Diff line number	Diff line change
`@@ -309,7 +309,7 @@ public function testNoIdentifiersException()`
`309`	`309`	`/**`
`310`	`310`	`* @group legacy`
`311`	`311`	`* @expectedDeprecation Not injecting "ApiPlatform\Core\Api\IdentifiersExtractorInterface" is deprecated since API Platform 2.1 and will not be possible anymore in API Platform 3`
`312`		`- * @expectedDeprecation Not injecting ApiPlatform\Core\Api\ResourceClassResolverInterface in the CachedIdentifiersExtractor might introduce cache issues with object identifiers.`
	`312`	`+ * @expectedDeprecation Not injecting ApiPlatform\Core\Api\ResourceClassResolverInterface in the IdentifiersExtractor might introduce cache issues with object identifiers.`
`313`	`313`	`*/`
`314`	`314`	`public function testLegacyConstructor()`
`315`	`315`	`{`