test(serializer): reproduce hal bug in test

Author: valentin-dassonville

tests/Fixtures/TestBundle/ApiResource/Issue4358/ResourceA.php

@@ -0,0 +1,51 @@
+<?php
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\Issue4358;
+
+
+use ApiPlatform\Metadata\ApiProperty;
+use ApiPlatform\Metadata\Get;
+use Symfony\Component\Serializer\Annotation\Groups;
+use Symfony\Component\Serializer\Annotation\MaxDepth;
+
+#[Get(uriTemplate: 'resource_a',
+    formats: ['jsonhal'],
+    outputFormats: ['jsonhal'],
+    normalizationContext: ['groups' => ['ResourceA:read'], 'enable_max_depth' => true],
+    provider: [self::class, 'provide'])]
+final class ResourceA
+{
+    private static ?ResourceA $resourceA = null;
+
+    #[ApiProperty(readableLink: true)]
+    #[Groups(['ResourceA:read', 'ResourceB:read'])]
+    #[MaxDepth(3)]
+    public ResourceB $b;
+    public function __construct(?ResourceB $b = null)
+    {
+        if ($b !== null) {
+            $this->b = $b;
+        }
+    }
+
+    public static function provide(): ResourceA
+    {
+        return self::provideWithResource();
+    }
+
+    public static function provideWithResource(?ResourceB $b = null): ResourceA {
+        if(!isset(self::$resourceA)) {
+            self::$resourceA = new ResourceA($b);
+
+            if(ResourceB::getInstance() === null) {
+                self::$resourceA->b = ResourceB::provideWithResource(self::$resourceA);
+            }
+        }
+        return self::$resourceA;
+    }
+
+    public static function getInstance(): ?ResourceA {
+        return self::$resourceA;
+    }
+
+}

tests/Fixtures/TestBundle/ApiResource/Issue4358/ResourceB.php

@@ -0,0 +1,53 @@
+<?php
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\Issue4358;
+
+use ApiPlatform\Metadata\ApiProperty;
+use ApiPlatform\Metadata\Get;
+use Symfony\Component\Serializer\Annotation\Groups;
+use Symfony\Component\Serializer\Annotation\MaxDepth;
+
+#[Get(uriTemplate: 'resource_b',
+    formats: ['jsonhal'],
+    outputFormats: ['jsonhal'],
+    normalizationContext: ['groups' => ['ResourceB:read'], 'enable_max_depth' => true],
+    provider: [self::class, 'provide'])]
+final class ResourceB
+{
+    private static ?ResourceB $resourceB = null;
+
+    #[ApiProperty(readableLink: true)]
+    #[Groups(['ResourceA:read', 'ResourceB:read'])]
+    #[MaxDepth(3)]
+    public ResourceA $a;
+
+    public function __construct(?ResourceA $a = null)
+    {
+        if ($a !== null) {
+            $this->a = $a;
+        }
+    }
+
+    public static function provide(): ResourceB
+    {
+        return self::provideWithResource();
+    }
+
+    public static function provideWithResource(?ResourceA $a = null): ResourceB
+    {
+        if(!isset(self::$resourceB)) {
+            self::$resourceB = new ResourceB($a);
+
+            if(ResourceA::getInstance() === null) {
+                self::$resourceB->a = ResourceA::provideWithResource(self::$resourceB);
+            }
+        }
+        return self::$resourceB;
+    }
+
+    public static function getInstance(): ?ResourceB
+    {
+        return self::$resourceB;
+    }
+
+}

tests/Fixtures/app/AppKernel.php

@@ -81,7 +81,7 @@ public function registerBundles(): array
         }
 
         if (class_exists(DoctrineMongoDBBundle::class)) {
-            $bundles[] = new DoctrineMongoDBBundle();
+            //$bundles[] = new DoctrineMongoDBBundle();
         }
 
         $bundles[] = new TestBundle();

tests/Functional/HALCircularReference.php

@@ -0,0 +1,25 @@
+<?php
+
+namespace ApiPlatform\Tests\Functional;
+
+use ApiPlatform\Symfony\Bundle\Test\ApiTestCase;
+use ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\Issue4358\ResourceA;
+use ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\Issue4358\ResourceB;
+use ApiPlatform\Tests\SetupClassResourcesTrait;
+
+class HALCircularReference extends ApiTestCase
+{
+    use SetupClassResourcesTrait;
+
+    public function testIssue4358()
+    {
+        $r1 = self::createClient()->request('GET', '/resource_a', ['headers' => ['Accept' => 'application/hal+json']]);
+        $this->assertResponseIsSuccessful();
+        echo $r1->getContent();
+    }
+
+    public static function getResources(): array
+    {
+        return [ResourceA::class, ResourceB::class];
+    }
+}