cs(doctrine): fix typing issues

Author: vinceAmstoutz

src/Doctrine/Odm/Filter/FilterInterface.php

@@ -28,7 +28,7 @@ interface FilterInterface extends BaseFilterInterface
     /**
      * Applies the filter.
      *
-     * @param array{'parameter'?: Parameter, ...} $context
+     * @param array|array{filters?: array<string, mixed>|array, parameter?: Parameter, mongodb_odm_sort_fields?: array, ...} $context
      */
     public function apply(Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void;
 }

src/Doctrine/Orm/Filter/ExistsFilter.php

@@ -142,8 +142,11 @@ public function apply(QueryBuilder $queryBuilder, QueryNameGeneratorInterface $q
             return;
         }
 
-        foreach ($context['filters'][$this->existsParameterName] ?? [] as $property => $value) {
-            $this->filterProperty($this->denormalizePropertyName($property), $value, $queryBuilder, $queryNameGenerator, $resourceClass, $operation, $context);
+        $properties = $context['filters'][$this->existsParameterName];
+        if ([] !== $properties) {
+            foreach ($properties as $property => $value) {
+                $this->filterProperty($this->denormalizePropertyName($property), $value, $queryBuilder, $queryNameGenerator, $resourceClass, $operation, $context);
+            }
         }
     }
 

src/Doctrine/Orm/Filter/FilterInterface.php

@@ -29,7 +29,7 @@ interface FilterInterface extends BaseFilterInterface
     /**
      * Applies the filter.
      *
-     * @param array{'parameter'?: Parameter} $context
+     * @param array{filters?: array<string, mixed>|array, parameter?: Parameter, ...} $context
      */
     public function apply(QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, ?Operation $operation = null, array $context = []): void;
 }

tests/Functional/Parameters/ExactFilterTest.php

@@ -136,10 +136,8 @@ private function loadFixtures(): void
         $chicken2->setName('Henriette');
         $chicken2->setChickenCoop($chickenCoop2);
 
-        if (method_exists($chickenCoop1, 'addChicken')) {
-            $chickenCoop1->addChicken($chicken1);
-            $chickenCoop2->addChicken($chicken2);
-        }
+        $chickenCoop1->addChicken($chicken1);
+        $chickenCoop2->addChicken($chicken2);
 
         $manager->persist($chickenCoop1);
         $manager->persist($chickenCoop2);

tests/Functional/Parameters/PartialSearchFilterTest.php

@@ -130,10 +130,8 @@ private function loadFixtures(): void
         $chicken2->setName('Henriette');
         $chicken2->setChickenCoop($chickenCoop2);
 
-        if (method_exists($chickenCoop1, 'addChicken')) {
-            $chickenCoop1->addChicken($chicken1);
-            $chickenCoop2->addChicken($chicken2);
-        }
+        $chickenCoop1->addChicken($chicken1);
+        $chickenCoop2->addChicken($chicken2);
 
         $manager->persist($chickenCoop1);
         $manager->persist($chickenCoop2);