fixes

soyuka · soyuka · commit 174bad02713e · 2025-11-28T23:18:20.000+01:00
diff --git a/src/Doctrine/Odm/Tests/PropertyInfo/DoctrineExtractorTest.php b/src/Doctrine/Odm/Tests/PropertyInfo/DoctrineExtractorTest.php
@@ -96,6 +96,7 @@ public function testExtractWithEmbedOneLegacy(): void
         if (!class_exists(LegacyType::class)) {
             $this->markTestSkipped();
         }
+
         $expectedTypes = [
             new LegacyType(
                 LegacyType::BUILTIN_TYPE_OBJECT,
@@ -126,6 +127,7 @@ public function testExtractWithEmbedManyLegacy(): void
         if (!class_exists(LegacyType::class)) {
             $this->markTestSkipped();
         }
+
         $expectedTypes = [
             new LegacyType(
                 LegacyType::BUILTIN_TYPE_OBJECT,
@@ -159,6 +161,7 @@ public function testExtractEnumLegacy(): void
         if (!class_exists(LegacyType::class)) {
             $this->markTestSkipped();
         }
+
         $this->assertEquals([new LegacyType(LegacyType::BUILTIN_TYPE_OBJECT, false, EnumString::class)], $this->createExtractor()->getTypes(DoctrineEnum::class, 'enumString'));
         $this->assertEquals([new LegacyType(LegacyType::BUILTIN_TYPE_OBJECT, false, EnumInt::class)], $this->createExtractor()->getTypes(DoctrineEnum::class, 'enumInt'));
         $this->assertNull($this->createExtractor()->getTypes(DoctrineEnum::class, 'enumCustom'));
@@ -200,7 +203,8 @@ public function testExtractLegacy(): void
             ['objectId', [new LegacyType(LegacyType::BUILTIN_TYPE_STRING)]],
             ['raw', null],
             ['foo', [new LegacyType(LegacyType::BUILTIN_TYPE_OBJECT, false, DoctrineRelation::class)]],
-            ['bar',
+            [
+                'bar',
                 [
                     new LegacyType(
                         LegacyType::BUILTIN_TYPE_OBJECT,
@@ -212,7 +216,8 @@ public function testExtractLegacy(): void
                     ),
                 ],
             ],
-            ['indexedFoo',
+            [
+                'indexedFoo',
                 [
                     new LegacyType(
                         LegacyType::BUILTIN_TYPE_OBJECT,
@@ -228,7 +233,7 @@ public function testExtractLegacy(): void
             ['notMapped', null],
         ];
 
-        foreach ($legacyTypes as $t) {
+        foreach ($legacyTypes as $property => $t) {
             $this->assertEquals($t, $this->createExtractor()->getTypes(DoctrineDummy::class, $property));
         }
     }
@@ -276,6 +281,7 @@ public function testGetTypesCatchExceptionLegacy(): void
         if (!class_exists(LegacyType::class)) {
             $this->markTestSkipped();
         }
+
         $this->assertNull($this->createExtractor()->getTypes('Not\Exist', 'baz'));
     }
 
@@ -299,6 +305,7 @@ public function testGetTypesWithEmbedManyOmittingTargetDocumentLegacy(): void
         if (!class_exists(LegacyType::class)) {
             $this->markTestSkipped();
         }
+
         $actualTypes = $this->createExtractor()->getTypes(
             DoctrineWithEmbedded::class,
             'embedManyOmittingTargetDocument'
diff --git a/src/GraphQl/Serializer/SerializerContextBuilder.php b/src/GraphQl/Serializer/SerializerContextBuilder.php
@@ -111,6 +111,6 @@ private function denormalizePropertyName(string $property, ?string $resourceClas
             return $property;
         }
 
-        return $this->nameConverter->denormalize($property, $resourceClass, null, $context); // @phpstan-ignore-line
+        return $this->nameConverter->denormalize($property, $resourceClass, null, $context);
     }
 }
diff --git a/src/State/composer.json b/src/State/composer.json
@@ -32,7 +32,8 @@
         "psr/container": "^1.0 || ^2.0",
         "symfony/http-kernel": "^6.4 || ^7.0 || ^8.0",
         "symfony/serializer": "^6.4 || ^7.0 || ^8.0",
-        "symfony/translation-contracts": "^3.0"
+        "symfony/translation-contracts": "^3.0",
+        "symfony/deprecation-contracts": "^3.1"
     },
     "require-dev": {
         "api-platform/serializer": "^4.2.4",
diff --git a/src/Symfony/Validator/Serializer/ValidationExceptionNormalizer.php b/src/Symfony/Validator/Serializer/ValidationExceptionNormalizer.php
@@ -14,7 +14,6 @@
 namespace ApiPlatform\Symfony\Validator\Serializer;
 
 use ApiPlatform\Validator\Exception\ValidationException;
-use Symfony\Component\Serializer\NameConverter\MetadataAwareNameConverter;
 use Symfony\Component\Serializer\NameConverter\NameConverterInterface;
 use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
 
@@ -30,10 +29,8 @@ public function normalize(mixed $object, ?string $format = null, array $context
         foreach ($object->getConstraintViolationList() as $violation) {
             $class = \is_object($root = $violation->getRoot()) ? $root::class : null;
 
-            if ($this->nameConverter instanceof MetadataAwareNameConverter) {
+            if ($this->nameConverter) {
                 $propertyPath = $this->nameConverter->normalize($violation->getPropertyPath(), $class, $format);
-            } elseif ($this->nameConverter instanceof NameConverterInterface) {
-                $propertyPath = $this->nameConverter->normalize($violation->getPropertyPath());
             } else {
                 $propertyPath = $violation->getPropertyPath();
             }
diff --git a/tests/Fixtures/app/config/reference.php b/tests/Fixtures/app/config/reference.php
@@ -453,8 +453,8 @@
  *             platform_service?: scalar|null, // Deprecated: The "platform_service" configuration key is deprecated since doctrine-bundle 2.9. DBAL 4 will not support setting a custom platform via connection params anymore.
  *             auto_commit?: bool,
  *             schema_filter?: scalar|null,
- *             logging?: bool, // Default: false
- *             profiling?: bool, // Default: false
+ *             logging?: bool, // Default: true
+ *             profiling?: bool, // Default: true
  *             profiling_collect_backtrace?: bool, // Enables collecting backtraces when profiling is enabled // Default: false
  *             profiling_collect_schema_errors?: bool, // Enables collecting schema errors when profiling is enabled // Default: true
  *             disable_type_comments?: bool,
@@ -593,7 +593,7 @@
  *                     pool?: scalar|null,
  *                 },
  *                 region_lock_lifetime?: scalar|null, // Default: 60
- *                 log_enabled?: bool, // Default: false
+ *                 log_enabled?: bool, // Default: true
  *                 region_lifetime?: scalar|null, // Default: 3600
  *                 enabled?: bool, // Default: true
  *                 factory?: scalar|null,
@@ -986,7 +986,7 @@
  *     http_method_override?: bool, // Set true to enable support for the '_method' request parameter to determine the intended HTTP method on POST requests. // Default: false
  *     allowed_http_method_override?: list<string>|null,
  *     trust_x_sendfile_type_header?: scalar|null, // Set true to enable support for xsendfile in binary file responses. // Default: "%env(bool:default::SYMFONY_TRUST_X_SENDFILE_TYPE_HEADER)%"
- *     ide?: scalar|null, // Default: null
+ *     ide?: scalar|null, // Default: "%env(default::SYMFONY_IDE)%"
  *     test?: bool,
  *     default_locale?: scalar|null, // Default: "en"
  *     set_locale_from_accept_language?: bool, // Whether to use the Accept-Language HTTP header to set the Request locale (only when the "_locale" request attribute is not passed). // Default: false
@@ -1143,7 +1143,7 @@
  *         paths?: array<string, scalar|null>,
  *         excluded_patterns?: list<scalar|null>,
  *         exclude_dotfiles?: bool, // If true, any files starting with "." will be excluded from the asset mapper. // Default: true
- *         server?: bool, // If true, a "dev server" will return the assets from the public directory (true in "debug" mode only by default). // Default: false
+ *         server?: bool, // If true, a "dev server" will return the assets from the public directory (true in "debug" mode only by default). // Default: true
  *         public_prefix?: scalar|null, // The public path where the assets will be written to (and served from when "server" is true). // Default: "/assets/"
  *         missing_import_mode?: "strict"|"warn"|"ignore", // Behavior if an asset cannot be found when imported from JavaScript or CSS files - e.g. "import './non-existent.js'". "strict" means an exception is thrown, "warn" means a warning is logged, "ignore" means the import is left as-is. // Default: "warn"
  *         extensions?: array<string, scalar|null>,
@@ -1263,7 +1263,7 @@
  *     },
  *     php_errors?: array{ // PHP errors handling configuration
  *         log?: mixed, // Use the application logger instead of the PHP logger for logging PHP errors. // Default: true
- *         throw?: bool, // Throw PHP errors as \ErrorException instances. // Default: false
+ *         throw?: bool, // Throw PHP errors as \ErrorException instances. // Default: true
  *     },
  *     exceptions?: array<string, array{ // Default: []
  *         log_level?: scalar|null, // The level of log message. Null to let Symfony decide. // Default: null
@@ -1326,7 +1326,7 @@
  *     scheduler?: bool|array{ // Scheduler configuration
  *         enabled?: bool, // Default: false
  *     },
- *     disallow_search_engine_index?: bool, // Enabled by default when debug is enabled. // Default: false
+ *     disallow_search_engine_index?: bool, // Enabled by default when debug is enabled. // Default: true
  *     http_client?: bool|array{ // HTTP Client configuration
  *         enabled?: bool, // Default: true
  *         max_host_connections?: int, // The maximum number of connections to a single host.

Original file line number	Diff line number	Diff line change
`@@ -111,6 +111,6 @@ private function denormalizePropertyName(string $property, ?string $resourceClas`
`111`	`111`	`return $property;`
`112`	`112`	`}`
`113`	`113`
`114`		`- return $this->nameConverter->denormalize($property, $resourceClass, null, $context); // @phpstan-ignore-line`
	`114`	`+ return $this->nameConverter->denormalize($property, $resourceClass, null, $context);`
`115`	`115`	`}`
`116`	`116`	`}`