test(laravel): #7337

Author: soyuka

src/Laravel/Tests/Eloquent/Filter/OrderFilterTest.php

@@ -0,0 +1,43 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Laravel\Tests;
+
+use ApiPlatform\Laravel\Test\ApiTestAssertionsTrait;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Support\Facades\DB;
+use Orchestra\Testbench\Concerns\WithWorkbench;
+use Orchestra\Testbench\TestCase;
+use Workbench\Database\Factories\ActiveBookFactory;
+
+class OrderFilterTest extends TestCase
+{
+    use ApiTestAssertionsTrait;
+    use RefreshDatabase;
+    use WithWorkbench;
+
+    public function testQueryParameterWithCamelCaseProperty(): void
+    {
+        ActiveBookFactory::new(['is_active' => true])->count(2)->create();
+        ActiveBookFactory::new(['is_active' => false])->count(3)->create();
+
+        DB::enableQueryLog();
+        $response = $this->get('/api/active_books?sort[isActive]=asc', ['Accept' => ['application/ld+json']]);
+        $response->assertStatus(200);
+        $this->assertEquals(\DB::getQueryLog()[1]['query'], 'select * from "active_books" order by "isActive" asc limit 30 offset 0');
+        DB::flushQueryLog();
+        $response = $this->get('/api/active_books?sort[isActive]=desc', ['Accept' => ['application/ld+json']]);
+        $response->assertStatus(200);
+        $this->assertEquals(DB::getQueryLog()[1]['query'], 'select * from "active_books" order by "isActive" desc limit 30 offset 0');
+    }
+}

src/Laravel/Tests/EloquentTest.php

@@ -19,7 +19,9 @@
 use Illuminate\Support\Str;
 use Orchestra\Testbench\Concerns\WithWorkbench;
 use Orchestra\Testbench\TestCase;
+use Workbench\App\Http\Requests\StoreSlotRequest;
 use Workbench\App\Models\PostWithMorphMany;
+use Workbench\Database\Factories\AreaFactory;
 use Workbench\Database\Factories\AuthorFactory;
 use Workbench\Database\Factories\BookFactory;
 use Workbench\Database\Factories\CommentMorphFactory;
@@ -614,4 +616,20 @@ public function testCreateDeliveryRequestWithPickupSlot(): void
             'note' => 'This is a test note.',
         ]);
     }
+
+    public function testIriIsNotDenormalizedBeforeFormRequestValidation(): void
+    {
+        $area = AreaFactory::new()->create();
+
+        $this->postJson(
+            '/api/slots',
+            [
+                'name' => 'Morning Slot',
+                'area' => '/api/areas/'.$area->id,
+            ],
+            ['accept' => 'application/ld+json', 'content-type' => 'application/ld+json']
+        )->assertStatus(201);
+
+        $this->assertSame(StoreSlotRequest::$receivedArea->name, $area->name);
+    }
 }

src/Laravel/workbench/app/ApiResource/SlotsForDate.php

@@ -1,5 +1,14 @@
 <?php
 
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 declare(strict_types=1);
 
 namespace Workbench\App\ApiResource;
@@ -24,7 +33,8 @@ class SlotsForDate
     public string $name = 'Morning Slot';
     public string $note = 'This is a morning slot';
 
-    public static function provide() {
+    public static function provide()
+    {
         return [];
     }
 }

src/Laravel/workbench/app/Http/Requests/GetDropOffSlotsRequest.php

@@ -1,5 +1,14 @@
 <?php
 
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 declare(strict_types=1);
 
 namespace Workbench\App\Http\Requests;
@@ -23,8 +32,8 @@ protected function prepareForValidation(): void
             'pickupDate' => $this->query('pickupDate'),
             'pickupSlotId' => $this->query('pickupSlotId'),
         ]);
-
     }
+
     /**
      * Get the validation rules that apply to the request.
      *
@@ -42,14 +51,9 @@ public function rules(): array
     protected function failedValidation(Validator $validator): void
     {
         $violations = collect($validator->errors())
-            ->map(fn($m, $f) => ['propertyPath' => $f, 'message' => $m[0]]) //** @phpstan-ignore-line */
+            ->map(fn ($m, $f) => ['propertyPath' => $f, 'message' => $m[0]]) // ** @phpstan-ignore-line */
             ->values()->all();
 
-        throw new \ApiPlatform\Laravel\ApiResource\ValidationError(
-            $violations[0]['message'] ?? 'Validation failed.',
-            hash('xxh3', implode(',', array_column($violations, 'propertyPath'))),
-            new \Illuminate\Validation\ValidationException($validator),
-            $violations
-        );
+        throw new \ApiPlatform\Laravel\ApiResource\ValidationError($violations[0]['message'] ?? 'Validation failed.', hash('xxh3', implode(',', array_column($violations, 'propertyPath'))), new \Illuminate\Validation\ValidationException($validator), $violations);
     }
 }

src/Laravel/workbench/app/Http/Requests/StoreSlotRequest.php

@@ -0,0 +1,47 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Workbench\App\Http\Requests;
+
+use ApiPlatform\Metadata\IriConverterInterface;
+use Illuminate\Foundation\Http\FormRequest;
+use Illuminate\Support\Facades\App;
+use Workbench\App\Models\Area;
+
+class StoreSlotRequest extends FormRequest
+{
+    public static ?Area $receivedArea = null;
+
+    public function authorize(): bool
+    {
+        return true;
+    }
+
+    public function rules(): array
+    {
+        $iriConverter = App::get(IriConverterInterface::class);
+
+        return [
+            'name' => ['required', 'string', 'max:255'],
+            'area' => [
+                'required',
+                'string',
+                function (string $attribute, mixed $value, \Closure $fail) use ($iriConverter): void {
+                    if (!(self::$receivedArea = $iriConverter->getResourceFromIri($value))) {
+                        $fail("The {$attribute} is invalid.");
+                    }
+                },
+            ],
+        ];
+    }
+}

src/Laravel/workbench/app/Models/Area.php

@@ -0,0 +1,34 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Workbench\App\Models;
+
+use ApiPlatform\Metadata\NotExposed;
+use Illuminate\Database\Eloquent\Factories\HasFactory;
+use Illuminate\Database\Eloquent\Model;
+use Illuminate\Database\Eloquent\Relations\HasMany;
+
+#[NotExposed]
+class Area extends Model
+{
+    use HasFactory;
+
+    protected $fillable = [
+        'name',
+    ];
+
+    public function slots(): HasMany
+    {
+        return $this->hasMany(Slot::class);
+    }
+}

src/Laravel/workbench/app/Models/Slot.php

@@ -14,16 +14,41 @@
 namespace Workbench\App\Models;
 
 use ApiPlatform\Metadata\ApiResource;
+use ApiPlatform\Metadata\Delete;
+use ApiPlatform\Metadata\Get;
+use ApiPlatform\Metadata\GetCollection;
+use ApiPlatform\Metadata\Patch;
+use ApiPlatform\Metadata\Post;
+use ApiPlatform\Metadata\Put;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
+use Illuminate\Database\Eloquent\Relations\BelongsTo;
+use Workbench\App\Http\Requests\StoreSlotRequest;
 
-#[ApiResource]
+#[ApiResource(
+    operations: [
+        new GetCollection(),
+        new Get(),
+        new Post(
+            rules: StoreSlotRequest::class,
+        ),
+        new Put(),
+        new Patch(),
+        new Delete(),
+    ],
+)]
 class Slot extends Model
 {
     use HasFactory;
+    protected $table = 'slots';
 
     protected $fillable = [
         'name',
-        'note',
+        'area_id',
     ];
+
+    public function area(): BelongsTo
+    {
+        return $this->belongsTo(Area::class);
+    }
 }

src/Laravel/workbench/database/factories/AreaFactory.php

@@ -0,0 +1,29 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Workbench\Database\Factories;
+
+use Illuminate\Database\Eloquent\Factories\Factory;
+use Workbench\App\Models\Area;
+
+class AreaFactory extends Factory
+{
+    protected $model = Area::class;
+
+    public function definition(): array
+    {
+        return [
+            'name' => $this->faker->city,
+        ];
+    }
+}

src/Laravel/workbench/database/factories/SlotFactory.php

@@ -0,0 +1,31 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Workbench\Database\Factories;
+
+use Illuminate\Database\Eloquent\Factories\Factory;
+use Workbench\App\Models\Area;
+use Workbench\App\Models\Slot;
+
+class SlotFactory extends Factory
+{
+    protected $model = Slot::class;
+
+    public function definition(): array
+    {
+        return [
+            'name' => $this->faker->name,
+            'area_id' => Area::factory(),
+        ];
+    }
+}

src/Laravel/workbench/database/migrations/2025_09_25_111111_create_slots_table.php

@@ -0,0 +1,39 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+return new class extends Migration {
+    public function up(): void
+    {
+        Schema::create('slots', function (Blueprint $table): void {
+            $table->id();
+            $table->string('name');
+            $table->foreignId('area_id')->constrained('areas')->onDelete('cascade');
+            $table->timestamps();
+        });
+        Schema::create('areas', function (Blueprint $table): void {
+            $table->id();
+            $table->string('name');
+            $table->timestamps();
+        });
+    }
+
+    public function down(): void
+    {
+        Schema::dropIfExists('slots');
+        Schema::dropIfExists('areas');
+    }
+};