fix(doctrine): group or filter in an AndWhere #7441 (#7445)

Author: soyuka

src/Doctrine/Orm/Filter/FreeTextQueryFilter.php

@@ -20,6 +20,7 @@
 use ApiPlatform\Doctrine\Orm\Util\QueryNameGeneratorInterface;
 use ApiPlatform\Metadata\BackwardCompatibleFilterDescriptionTrait;
 use ApiPlatform\Metadata\Operation;
+use Doctrine\Common\Collections\ArrayCollection;
 use Doctrine\ORM\QueryBuilder;
 
 final class FreeTextQueryFilter implements FilterInterface, ManagerRegistryAwareInterface, LoggerAwareInterface
@@ -46,14 +47,26 @@ public function apply(QueryBuilder $queryBuilder, QueryNameGeneratorInterface $q
         }
 
         $parameter = $context['parameter'];
+        $qb = clone $queryBuilder;
+        $qb->resetDQLPart('where');
+        $qb->setParameters(new ArrayCollection());
         foreach ($this->properties ?? $parameter->getProperties() ?? [] as $property) {
             $this->filter->apply(
-                $queryBuilder,
+                $qb,
                 $queryNameGenerator,
                 $resourceClass,
                 $operation,
                 ['parameter' => $parameter->withProperty($property)] + $context
             );
         }
+
+        $queryBuilder->andWhere($qb->getDQLPart('where'));
+        $parameters = $queryBuilder->getParameters();
+
+        foreach ($qb->getParameters() as $p) {
+            $parameters->add($p);
+        }
+
+        $queryBuilder->setParameters($parameters);
     }
 }

tests/Functional/Parameters/OrFilterTest.php

@@ -20,6 +20,7 @@
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\ChickenCoop;
 use ApiPlatform\Tests\RecreateSchemaTrait;
 use ApiPlatform\Tests\SetupClassResourcesTrait;
+use Doctrine\Bundle\DoctrineBundle\DataCollector\DoctrineDataCollector;
 use Doctrine\ODM\MongoDB\MongoDBException;
 use PHPUnit\Framework\Attributes\DataProvider;
 
@@ -62,6 +63,22 @@ public function testOrFilter(string $url, int $expectedCount): void
         $this->assertJsonContains(['totalItems' => $expectedCount]);
     }
 
+    public function testOrFilterWithAnd(): void
+    {
+        if ($this->isMongoDB()) {
+            $this->markTestSkipped();
+        }
+        $client = self::createClient();
+        $client->enableProfiler();
+        $client->request('GET', '/chickens?autocomplete=978020137962&chickenCoop=/chicken_coops/2');
+        $profile = $client->getProfile();
+        $this->assertResponseIsSuccessful();
+
+        /** @var DoctrineDataCollector */
+        $db = $profile->getCollector('db');
+        $this->assertStringContainsString('WHERE c1_.id = ? AND (c2_.name = ? OR c2_.ean = ?))', end($db->getQueries()['default'])['sql']);
+    }
+
     public static function orFilterDataProvider(): \Generator
     {
         yield 'ean through autocomplete' => [