fix: solve some baseline errors

Author: VincentLanglet

phpstan.neon.dist

@@ -50,7 +50,6 @@ parameters:
 			message: '#but database expects#'
 			paths:
 				- tests/Fixtures/TestBundle/Entity/
-		- '#Cannot call method add\(\) on iterable.#'
 		-
 			message: '#is never read, only written.#'
 			paths:

src/Doctrine/Common/Tests/Fixtures/TestBundle/Entity/Dummy.php

@@ -104,7 +104,7 @@ class Dummy
     public ?RelatedDummy $relatedDummy = null;
 
     #[ORM\ManyToMany(targetEntity: RelatedDummy::class)]
-    public Collection|iterable $relatedDummies;
+    public Collection $relatedDummies;
 
     /**
      * @var array|null serialize data
@@ -302,7 +302,7 @@ public function getDummy()
         return $this->dummy;
     }
 
-    public function getRelatedDummies(): Collection|iterable
+    public function getRelatedDummies(): Collection
     {
         return $this->relatedDummies;
     }

src/Doctrine/Common/Tests/Fixtures/TestBundle/Entity/FourthLevel.php

@@ -46,7 +46,7 @@ class FourthLevel
     #[Groups(['barcelona', 'chicago'])]
     private int $level = 4;
     #[ORM\OneToMany(targetEntity: ThirdLevel::class, cascade: ['persist'], mappedBy: 'badFourthLevel')]
-    public Collection|iterable|null $badThirdLevel = null;
+    public ?Collection $badThirdLevel = null;
 
     public function getId(): ?int
     {

src/Doctrine/Common/Tests/Fixtures/TestBundle/Entity/RelatedDummy.php

@@ -84,7 +84,7 @@ class RelatedDummy extends ParentDummy implements \Stringable
 
     #[ORM\OneToMany(targetEntity: RelatedToDummyFriend::class, cascade: ['persist'], mappedBy: 'relatedDummy')]
     #[Groups(['fakemanytomany', 'friends'])]
-    public Collection|iterable $relatedToDummyFriend;
+    public Collection $relatedToDummyFriend;
 
     /**
      * @var bool|null A dummy bool
@@ -169,7 +169,7 @@ public function setThirdLevel(?ThirdLevel $thirdLevel = null): void
     /**
      * Get relatedToDummyFriend.
      */
-    public function getRelatedToDummyFriend(): Collection|iterable
+    public function getRelatedToDummyFriend(): Collection
     {
         return $this->relatedToDummyFriend;
     }

src/Doctrine/Odm/Tests/Fixtures/Document/Dummy.php

@@ -77,7 +77,7 @@ class Dummy
     #[ODM\ReferenceOne(targetDocument: RelatedDummy::class, storeAs: 'id', nullable: true)]
     public ?RelatedDummy $relatedDummy = null;
     #[ODM\ReferenceMany(targetDocument: RelatedDummy::class, storeAs: 'id', nullable: true)]
-    public Collection|iterable $relatedDummies;
+    public Collection $relatedDummies;
     #[ODM\Field(type: 'hash', nullable: true)]
     public array $jsonData = [];
     #[ODM\Field(type: 'collection', nullable: true)]

src/Doctrine/Odm/Tests/Fixtures/Document/FourthLevel.php

@@ -32,7 +32,7 @@ class FourthLevel
     #[ODM\Field(type: 'int')]
     private ?int $level = 4;
     #[ODM\ReferenceMany(targetDocument: ThirdLevel::class, cascade: ['persist'], mappedBy: 'badFourthLevel', storeAs: 'id')]
-    public Collection|iterable|null $badThirdLevel = null;
+    public ?Collection $badThirdLevel = null;
 
     public function getId(): ?int
     {

src/Doctrine/Odm/Tests/Fixtures/Document/RelatedDummy.php

@@ -43,7 +43,7 @@ class RelatedDummy extends ParentDummy implements \Stringable
     #[ODM\ReferenceOne(targetDocument: ThirdLevel::class, cascade: ['persist'], nullable: true, storeAs: 'id', inversedBy: 'relatedDummies')]
     public ?ThirdLevel $thirdLevel = null;
     #[ODM\ReferenceMany(targetDocument: RelatedToDummyFriend::class, cascade: ['persist'], mappedBy: 'relatedDummy', storeAs: 'id')]
-    public Collection|iterable $relatedToDummyFriend;
+    public Collection $relatedToDummyFriend;
     #[ODM\Field(type: 'bool')]
     public ?bool $dummyBoolean = null;
     #[ODM\EmbedOne(targetDocument: EmbeddableDummy::class)]
@@ -121,7 +121,7 @@ public function setThirdLevel(?ThirdLevel $thirdLevel = null): void
     /**
      * Get relatedToDummyFriend.
      */
-    public function getRelatedToDummyFriend(): Collection|iterable
+    public function getRelatedToDummyFriend(): Collection
     {
         return $this->relatedToDummyFriend;
     }

src/Doctrine/Odm/Tests/Fixtures/Document/ThirdLevel.php

@@ -40,7 +40,7 @@ class ThirdLevel
     #[ODM\ReferenceOne(targetDocument: FourthLevel::class, cascade: ['persist'])]
     public $badFourthLevel;
     #[ODM\ReferenceMany(mappedBy: 'thirdLevel', targetDocument: RelatedDummy::class)]
-    public Collection|iterable $relatedDummies;
+    public Collection $relatedDummies;
 
     public function __construct()
     {

src/Doctrine/Orm/Tests/Fixtures/Entity/CompositeItem.php

@@ -35,7 +35,7 @@ class CompositeItem implements \Stringable
     private ?string $field1 = null;
     #[ORM\OneToMany(targetEntity: CompositeRelation::class, mappedBy: 'compositeItem', fetch: 'EAGER')]
     #[Groups(['default'])]
-    private Collection|iterable $compositeValues;
+    private Collection $compositeValues;
 
     public function __construct()
     {
@@ -71,7 +71,7 @@ public function setField1($field1 = null): void
     /**
      * Gets compositeValues.
      */
-    public function getCompositeValues(): Collection|iterable
+    public function getCompositeValues(): Collection
     {
         return $this->compositeValues;
     }

src/Doctrine/Orm/Tests/Fixtures/Entity/Dummy.php

@@ -107,7 +107,7 @@ class Dummy
     public ?RelatedDummy $relatedDummy = null;
 
     #[ORM\ManyToMany(targetEntity: RelatedDummy::class)]
-    public Collection|iterable $relatedDummies;
+    public Collection $relatedDummies;
 
     /**
      * @var array|null serialize data
@@ -305,7 +305,7 @@ public function getDummy()
         return $this->dummy;
     }
 
-    public function getRelatedDummies(): Collection|iterable
+    public function getRelatedDummies(): Collection
     {
         return $this->relatedDummies;
     }