make classes final + consistency in service name

Author: jdeniau

src/Bridge/Symfony/Bundle/Resources/config/validator.xml

@@ -23,7 +23,7 @@
             <tag name="kernel.event_listener" event="kernel.view" method="onKernelView" priority="64" />
         </service>
 
-        <service id="ApiPlatform\Core\Filter\QueryParameterValidateListener">
+        <service id="api_platform.listener.view.validate_query_parameters" class="ApiPlatform\Core\Filter\QueryParameterValidateListener" public="false">
             <argument type="service" id="api_platform.metadata.resource.metadata_factory" />
             <argument type="service" id="api_platform.filter_locator" />
 

src/Exception/FilterValidationException.php

@@ -18,7 +18,7 @@
  *
  * @author Julien DENIAU <[email protected]>
  */
-class FilterValidationException extends \Exception implements ExceptionInterface
+final class FilterValidationException extends \Exception implements ExceptionInterface
 {
     private $constraintViolationList;
 

src/Filter/QueryParameterValidateListener.php

@@ -25,7 +25,7 @@
  *
  * @author Julien Deniau <[email protected]>
  */
-class QueryParameterValidateListener
+final class QueryParameterValidateListener
 {
     use FilterLocatorTrait;
 

tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php

@@ -521,7 +521,7 @@ private function getPartialContainerBuilderProphecy($test = false)
             'api_platform.listener.view.respond',
             'api_platform.listener.view.serialize',
             'api_platform.listener.view.validate',
-            'ApiPlatform\Core\Filter\QueryParameterValidateListener',
+            'api_platform.listener.view.validate_query_parameters',
             'api_platform.listener.view.write',
             'api_platform.metadata.extractor.xml',
             'api_platform.metadata.property.metadata_factory.cached',

tests/Fixtures/TestBundle/Entity/ArrayFilterValidator.php

@@ -54,11 +54,6 @@ public function getId()
         return $this->id;
     }
 
-    public function setId($id)
-    {
-        $this->id = $id;
-    }
-
     public function setName($name)
     {
         $this->name = $name;

tests/Fixtures/TestBundle/Entity/FilterValidator.php

@@ -54,11 +54,6 @@ public function getId()
         return $this->id;
     }
 
-    public function setId($id)
-    {
-        $this->id = $id;
-    }
-
     public function setName($name)
     {
         $this->name = $name;

tests/Fixtures/TestBundle/Filter/ArrayRequiredFilter.php

@@ -17,7 +17,7 @@
 use ApiPlatform\Core\Bridge\Doctrine\Orm\Util\QueryNameGeneratorInterface;
 use Doctrine\ORM\QueryBuilder;
 
-class ArrayRequiredFilter extends AbstractFilter
+final class ArrayRequiredFilter extends AbstractFilter
 {
     protected function filterProperty(string $property, $value, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, string $operationName = null)
     {

tests/Fixtures/TestBundle/Filter/RequiredFilter.php

@@ -17,7 +17,7 @@
 use ApiPlatform\Core\Bridge\Doctrine\Orm\Util\QueryNameGeneratorInterface;
 use Doctrine\ORM\QueryBuilder;
 
-class RequiredFilter extends AbstractFilter
+final class RequiredFilter extends AbstractFilter
 {
     protected function filterProperty(string $property, $value, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, string $operationName = null)
     {

tests/Fixtures/app/config/config_test.yml

@@ -166,12 +166,12 @@ services:
         tags:      [ { name: 'api_platform.filter', id: 'my_dummy.property' } ]
 
     ApiPlatform\Core\Tests\Fixtures\TestBundle\Filter\RequiredFilter:
-        arguments: [ '@doctrine' ]
-        tags: [ 'api_platform.filter' ]
+        arguments: ['@doctrine']
+        tags: ['api_platform.filter']
 
     ApiPlatform\Core\Tests\Fixtures\TestBundle\Filter\ArrayRequiredFilter:
-        arguments: [ '@doctrine' ]
-        tags: [ 'api_platform.filter' ]
+        arguments: ['@doctrine']
+        tags: ['api_platform.filter']
 
     app.config_dummy_resource.action:
         class: 'ApiPlatform\Core\Tests\Fixtures\TestBundle\Action\ConfigCustom'