Enable phpdoc_add_missing_param_annotation rule

Author: teohhanhui

.php_cs.dist

@@ -88,6 +88,9 @@ return PhpCsFixer\Config::create()
         'php_unit_test_annotation' => [
             'style' => 'prefix',
         ],
+        'phpdoc_add_missing_param_annotation' => [
+            'only_untyped' => true,
+        ],
         'phpdoc_order' => true,
         'phpdoc_trim_consecutive_blank_line_separation' => true,
         'phpdoc_var_annotation_correct_order' => true,

src/Bridge/Doctrine/Common/Filter/SearchFilterTrait.php

@@ -150,6 +150,8 @@ protected function normalizeValues(array $values, string $property): ?array
 
     /**
      * When the field should be an integer, check that the given value is a valid one.
+     *
+     * @param mixed|null $type
      */
     protected function hasValidValues(array $values, $type = null): bool
     {

src/DataProvider/Pagination.php

@@ -180,6 +180,8 @@ private function getEnabled(array $context, string $resourceClass = null, string
 
     /**
      * Gets the given pagination parameter name from the given context.
+     *
+     * @param mixed|null $default
      */
     private function getParameterFromContext(array $context, string $parameterName, $default = null)
     {

src/GraphQl/ExecutorInterface.php

@@ -27,6 +27,9 @@ interface ExecutorInterface
 {
     /**
      * @see http://webonyx.github.io/graphql-php/executing-queries/#using-facade-method
+     *
+     * @param mixed|null $rootValue
+     * @param mixed|null $context
      */
     public function executeQuery(Schema $schema, $source, $rootValue = null, $context = null, array $variableValues = null, string $operationName = null, callable $fieldResolver = null, array $validationRules = null): ExecutionResult;
 }

src/GraphQl/Resolver/ResourceAccessCheckerTrait.php

@@ -28,6 +28,8 @@
 trait ResourceAccessCheckerTrait
 {
     /**
+     * @param mixed|null $object
+     *
      * @throws Error
      */
     public function canAccess(?ResourceAccessCheckerInterface $resourceAccessChecker, ResourceMetadata $resourceMetadata, string $resourceClass, ResolveInfo $info, $object = null, string $operationName = null): void

src/Hydra/Serializer/CollectionNormalizer.php

@@ -62,6 +62,8 @@ public function supportsNormalization($data, $format = null)
 
     /**
      * {@inheritdoc}
+     *
+     * @param iterable $object
      */
     public function normalize($object, $format = null, array $context = [])
     {
@@ -117,7 +119,7 @@ public function hasCacheableSupportsMethod(): bool
     /**
      * Normalizes a raw collection (not API resources).
      */
-    private function normalizeRawCollection($object, $format = null, array $context = []): array
+    private function normalizeRawCollection(iterable $object, ?string $format, array $context): array
     {
         $data = [];
         foreach ($object as $index => $obj) {

src/Metadata/Property/PropertyMetadata.php

@@ -238,6 +238,8 @@ public function getAttributes(): ?array
 
     /**
      * Gets an attribute.
+     *
+     * @param mixed|null $defaultValue
      */
     public function getAttribute(string $key, $defaultValue = null)
     {

src/Metadata/Resource/ResourceMetadata.php

@@ -159,6 +159,8 @@ public function withSubresourceOperations(array $subresourceOperations): self
 
     /**
      * Gets a collection operation attribute, optionally fallback to a resource attribute.
+     *
+     * @param mixed|null $defaultValue
      */
     public function getCollectionOperationAttribute(?string $operationName, string $key, $defaultValue = null, bool $resourceFallback = false)
     {
@@ -167,6 +169,8 @@ public function getCollectionOperationAttribute(?string $operationName, string $
 
     /**
      * Gets an item operation attribute, optionally fallback to a resource attribute.
+     *
+     * @param mixed|null $defaultValue
      */
     public function getItemOperationAttribute(?string $operationName, string $key, $defaultValue = null, bool $resourceFallback = false)
     {
@@ -175,28 +179,14 @@ public function getItemOperationAttribute(?string $operationName, string $key, $
 
     /**
      * Gets a subresource operation attribute, optionally fallback to a resource attribute.
+     *
+     * @param mixed|null $defaultValue
      */
     public function getSubresourceOperationAttribute(?string $operationName, string $key, $defaultValue = null, bool $resourceFallback = false)
     {
         return $this->findOperationAttribute($this->subresourceOperations, $operationName, $key, $defaultValue, $resourceFallback);
     }
 
-    /**
-     * Gets an operation attribute, optionally fallback to a resource attribute.
-     */
-    private function findOperationAttribute(?array $operations, ?string $operationName, string $key, $defaultValue = null, bool $resourceFallback = false)
-    {
-        if (null !== $operationName && isset($operations[$operationName][$key])) {
-            return $operations[$operationName][$key];
-        }
-
-        if ($resourceFallback && isset($this->attributes[$key])) {
-            return $this->attributes[$key];
-        }
-
-        return $defaultValue;
-    }
-
     public function getGraphqlAttribute(string $operationName, string $key, $defaultValue = null, bool $resourceFallback = false)
     {
         if (isset($this->graphql[$operationName][$key])) {
@@ -212,6 +202,8 @@ public function getGraphqlAttribute(string $operationName, string $key, $default
 
     /**
      * Gets the first available operation attribute according to the following order: collection, item, subresource, optionally fallback to a default value.
+     *
+     * @param mixed|null $defaultValue
      */
     public function getOperationAttribute(array $attributes, string $key, $defaultValue = null, bool $resourceFallback = false)
     {
@@ -236,6 +228,8 @@ public function getOperationAttribute(array $attributes, string $key, $defaultVa
 
     /**
      * Gets an attribute for a given operation type and operation name.
+     *
+     * @param mixed|null $defaultValue
      */
     public function getTypedOperationAttribute(string $operationType, string $operationName, string $key, $defaultValue = null, bool $resourceFallback = false)
     {
@@ -259,6 +253,8 @@ public function getAttributes(): ?array
 
     /**
      * Gets an attribute.
+     *
+     * @param mixed|null $defaultValue
      */
     public function getAttribute(string $key, $defaultValue = null)
     {
@@ -294,4 +290,22 @@ public function withGraphql(array $graphql): self
 
         return $metadata;
     }
+
+    /**
+     * Gets an operation attribute, optionally fallback to a resource attribute.
+     *
+     * @param mixed|null $defaultValue
+     */
+    private function findOperationAttribute(?array $operations, ?string $operationName, string $key, $defaultValue, bool $resourceFallback)
+    {
+        if (null !== $operationName && isset($operations[$operationName][$key])) {
+            return $operations[$operationName][$key];
+        }
+
+        if ($resourceFallback && isset($this->attributes[$key])) {
+            return $this->attributes[$key];
+        }
+
+        return $defaultValue;
+    }
 }

src/Serializer/AbstractCollectionNormalizer.php

@@ -96,6 +96,8 @@ public function normalize($object, $format = null, array $context = [])
 
     /**
      * Normalizes a raw collection (not API resources).
+     *
+     * @param string|null $format
      */
     protected function normalizeRawCollection($object, $format = null, array $context = []): array
     {

tests/Metadata/Property/Factory/AnnotationSubresourceMetadataFactoryTest.php

@@ -32,7 +32,7 @@ class AnnotationSubresourceMetadataFactoryTest extends TestCase
     /**
      * @dataProvider dependenciesProvider
      */
-    public function testCreateProperty($reader, $decorated = null)
+    public function testCreateProperty($reader, $decorated)
     {
         $factory = new AnnotationSubresourceMetadataFactory($reader->reveal(), $decorated->reveal());
         $metadata = $factory->create(Dummy::class, 'relatedDummies');