feature/serializer-remove-method-instantiateObject-from-AbstractItemNormalizer

Author: alexndlm

src/Serializer/AbstractItemNormalizer.php

@@ -289,91 +289,6 @@ public function denormalize(mixed $data, string $class, ?string $format = null,
         return $object;
     }
 
-    /**
-     * Method copy-pasted from symfony/serializer.
-     * Remove it after symfony/serializer version update @see https://github.com/symfony/symfony/pull/28263.
-     *
-     * {@inheritdoc}
-     *
-     * @internal
-     */
-    protected function instantiateObject(array &$data, string $class, array &$context, \ReflectionClass $reflectionClass, array|bool $allowedAttributes, ?string $format = null): object
-    {
-        if (null !== $object = $this->extractObjectToPopulate($class, $context, static::OBJECT_TO_POPULATE)) {
-            unset($context[static::OBJECT_TO_POPULATE]);
-
-            return $object;
-        }
-
-        $class = $this->getClassDiscriminatorResolvedClass($data, $class, $context);
-        $reflectionClass = new \ReflectionClass($class);
-
-        $constructor = $this->getConstructor($data, $class, $context, $reflectionClass, $allowedAttributes);
-        if ($constructor) {
-            $constructorParameters = $constructor->getParameters();
-
-            $params = [];
-            $missingConstructorArguments = [];
-            foreach ($constructorParameters as $constructorParameter) {
-                $paramName = $constructorParameter->name;
-                $key = $this->nameConverter ? $this->nameConverter->normalize($paramName, $class, $format, $context) : $paramName;
-
-                $allowed = false === $allowedAttributes || (\is_array($allowedAttributes) && \in_array($paramName, $allowedAttributes, true));
-                $ignored = !$this->isAllowedAttribute($class, $paramName, $format, $context);
-                if ($constructorParameter->isVariadic()) {
-                    if ($allowed && !$ignored && (isset($data[$key]) || \array_key_exists($key, $data))) {
-                        if (!\is_array($data[$paramName])) {
-                            throw new RuntimeException(\sprintf('Cannot create an instance of %s from serialized data because the variadic parameter %s can only accept an array.', $class, $constructorParameter->name));
-                        }
-
-                        $params[] = $data[$paramName];
-                    }
-                } elseif ($allowed && !$ignored && (isset($data[$key]) || \array_key_exists($key, $data))) {
-                    $constructorContext = $context;
-                    $constructorContext['deserialization_path'] = $context['deserialization_path'] ?? $key;
-                    try {
-                        $params[] = $this->createConstructorArgument($data[$key], $key, $constructorParameter, $constructorContext, $format);
-                    } catch (NotNormalizableValueException $exception) {
-                        if (!isset($context['not_normalizable_value_exceptions'])) {
-                            throw $exception;
-                        }
-                        $context['not_normalizable_value_exceptions'][] = $exception;
-                    }
-
-                    // Don't run set for a parameter passed to the constructor
-                    unset($data[$key]);
-                } elseif (isset($context[static::DEFAULT_CONSTRUCTOR_ARGUMENTS][$class][$key])) {
-                    $params[] = $context[static::DEFAULT_CONSTRUCTOR_ARGUMENTS][$class][$key];
-                } elseif ($constructorParameter->isDefaultValueAvailable()) {
-                    $params[] = $constructorParameter->getDefaultValue();
-                } else {
-                    if (!isset($context['not_normalizable_value_exceptions'])) {
-                        $missingConstructorArguments[] = $constructorParameter->name;
-                    }
-
-                    $exception = NotNormalizableValueException::createForUnexpectedDataType(\sprintf('Failed to create object because the class misses the "%s" property.', $constructorParameter->name), $data, ['unknown'], $context['deserialization_path'] ?? null, true);
-                    $context['not_normalizable_value_exceptions'][] = $exception;
-                }
-            }
-
-            if ($missingConstructorArguments) {
-                throw new MissingConstructorArgumentsException(\sprintf('Cannot create an instance of "%s" from serialized data because its constructor requires the following parameters to be present : "$%s".', $class, implode('", "$', $missingConstructorArguments)), 0, null, $missingConstructorArguments, $class);
-            }
-
-            if (\count($context['not_normalizable_value_exceptions'] ?? []) > 0) {
-                return $reflectionClass->newInstanceWithoutConstructor();
-            }
-
-            if ($constructor->isConstructor()) {
-                return $reflectionClass->newInstanceArgs($params);
-            }
-
-            return $constructor->invokeArgs(null, $params);
-        }
-
-        return new $class();
-    }
-
     protected function getClassDiscriminatorResolvedClass(array $data, string $class, array $context = []): string
     {
         if (null === $this->classDiscriminatorResolver || (null === $mapping = $this->classDiscriminatorResolver->getMappingForClass($class))) {