fix(serializer): hal format circular reference detection

Author: valentin-dassonville

src/Hal/Serializer/ItemNormalizer.php

@@ -33,6 +33,7 @@
 use Symfony\Component\Serializer\Mapping\Factory\ClassMetadataFactoryInterface;
 use Symfony\Component\Serializer\NameConverter\NameConverterInterface;
 use Symfony\Component\Serializer\Normalizer\AbstractNormalizer;
+use Symfony\Component\Serializer\Normalizer\AbstractObjectNormalizer;
 
 /**
  * Converts between objects and array including HAL metadata.
@@ -59,7 +60,6 @@ public function __construct(PropertyNameCollectionFactoryInterface $propertyName
             if (null === $iri) {
                 return null;
             }
-
             return ['_links' => ['self' => ['href' => $iri]]];
         };
 
@@ -84,10 +84,6 @@ public function getSupportedTypes($format): array
      */
     public function normalize(mixed $object, ?string $format = null, array $context = []): array|string|int|float|bool|\ArrayObject|null
     {
-        if ($this->isHalCircularReference($object, $context)) {
-            return $this->handleHalCircularReference($object, $format, $context);
-        }
-
         $resourceClass = $this->getObjectClass($object);
         if ($this->getOutputClass($context)) {
             return parent::normalize($object, $format, $context);
@@ -248,6 +244,10 @@ private function populateRelation(array $data, object $object, ?string $format,
     {
         $class = $this->getObjectClass($object);
 
+        if ($this->isHalCircularReference($object, $context)) {
+            return $this->handleHalCircularReference($object, $format, $context);
+        }
+
         $attributesMetadata = \array_key_exists($class, $this->attributesMetadataCache) ?
             $this->attributesMetadataCache[$class] :
             $this->attributesMetadataCache[$class] = $this->classMetadataFactory ? $this->classMetadataFactory->getMetadataFor($class)->getAttributesMetadata() : null;