fix: remove legacy code

Author: vincentchalamon

src/HttpCache/EventListener/AddTagsListener.php

@@ -70,10 +70,9 @@ public function onKernelResponse(ResponseEvent $event): void
         }
 
         $resources = $request->attributes->get('_resources');
-        if (isset($attributes['collection_operation_name']) || ($attributes['subresource_context']['collection'] ?? false) || ($operation && $operation instanceof CollectionOperationInterface)) {
+        if ($operation instanceof CollectionOperationInterface) {
             // Allows to purge collections
             $uriVariables = $this->getOperationUriVariables($operation, $request->attributes->all(), $attributes['resource_class']);
-
             $iri = $this->iriConverter->getIriFromResource($attributes['resource_class'], UrlGeneratorInterface::ABS_PATH, $operation, ['uri_variables' => $uriVariables]);
 
             $resources[$iri] = $iri;

src/Metadata/Resource/Factory/AlternateUriResourceMetadataCollectionFactory.php

@@ -39,7 +39,7 @@ public function create(string $resourceClass): ResourceMetadataCollection
         }
 
         foreach ($resourceMetadataCollection as $i => $resource) {
-            if (0 === $i || ($resource->getExtraProperties()['is_legacy_subresource'] ?? false) || ($resource->getExtraProperties()['is_legacy_resource_metadata'] ?? false)) {
+            if (0 === $i) {
                 continue;
             }
 

src/Metadata/Resource/Factory/OperationNameResourceMetadataCollectionFactory.php

@@ -57,13 +57,6 @@ public function create(string $resourceClass): ResourceMetadataCollection
                 }
 
                 $newOperationName = sprintf('_api_%s_%s%s', $operation->getUriTemplate() ?: $operation->getShortName(), strtolower($operation->getMethod() ?? HttpOperation::METHOD_GET), $operation instanceof CollectionOperationInterface ? '_collection' : '');
-
-                // TODO: remove in 3.0 this is used in the IRI converter to avoid a bc break
-                if (($extraProperties = $operation->getExtraProperties()) && isset($extraProperties['is_legacy_subresource'])) {
-                    $extraProperties['legacy_subresource_operation_name'] = $newOperationName;
-                    $operation = $operation->withExtraProperties($extraProperties);
-                }
-
                 $operations->remove($operationName)->add($newOperationName, $operation->withName($newOperationName));
             }
 

src/Metadata/Resource/Factory/UriTemplateResourceMetadataCollectionFactory.php

@@ -102,10 +102,6 @@ private function generateUriTemplate(HttpOperation $operation): string
         $uriVariables = $operation->getUriVariables() ?? [];
 
         if ($parameters = array_keys($uriVariables)) {
-            if (($operation->getExtraProperties()['is_legacy_resource_metadata'] ?? false) && 1 < \count($uriVariables[$parameters[0]]->getIdentifiers() ?? [])) {
-                $parameters[0] = 'id';
-            }
-
             foreach ($parameters as $parameterName) {
                 $uriTemplate .= sprintf('/{%s}', $parameterName);
             }

src/Symfony/Bundle/Resources/config/api.xml

@@ -88,7 +88,6 @@
         <service id="api_platform.action.patch_item" alias="api_platform.action.placeholder" public="true" />
         <service id="api_platform.action.put_item" alias="api_platform.action.placeholder" public="true" />
         <service id="api_platform.action.delete_item" alias="api_platform.action.placeholder" public="true" />
-        <service id="api_platform.action.get_subresource" alias="api_platform.action.placeholder" public="true" />
         <service id="api_platform.action.not_found" class="ApiPlatform\Action\NotFoundAction" public="true" />
         <service id="ApiPlatform\Action\NotFoundAction" alias="api_platform.action.not_found" public="true" />
 

src/Symfony/Bundle/Resources/config/symfony/events.xml

@@ -83,7 +83,6 @@
                 <argument>api_platform.cache.metadata.resource_collection</argument>
                 <argument>api_platform.cache.route_name_resolver</argument>
                 <argument>api_platform.cache.identifiers_extractor</argument>
-                <argument>api_platform.cache.subresource_operation_factory</argument>
                 <argument>api_platform.elasticsearch.cache.metadata.document</argument>
             </argument>
             <tag name="kernel.cache_warmer" priority="64" />