Merge pull request #1020 from teohhanhui/hotfix/eager-loading-disabled

Remove FilterEagerLoadingExtension when eager loading is disabled

Author: soyuka

src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php

@@ -285,6 +285,7 @@ private function registerDoctrineExtensionConfiguration(ContainerBuilder $contai
     {
         if (false === $config['eager_loading']['enabled']) {
             $container->removeDefinition('api_platform.doctrine.orm.query_extension.eager_loading');
+            $container->removeDefinition('api_platform.doctrine.orm.query_extension.filter_eager_loading');
         }
     }
 

tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php

@@ -170,6 +170,7 @@ public function testDisableEagerLoadingExtension()
         $containerBuilderProphecy = $this->getContainerBuilderProphecy();
         $containerBuilderProphecy->setParameter('api_platform.eager_loading.enabled', false)->shouldBeCalled();
         $containerBuilderProphecy->removeDefinition('api_platform.doctrine.orm.query_extension.eager_loading')->shouldBeCalled();
+        $containerBuilderProphecy->removeDefinition('api_platform.doctrine.orm.query_extension.filter_eager_loading')->shouldBeCalled();
         $containerBuilder = $containerBuilderProphecy->reveal();
         $this->extension->load(array_merge_recursive(self::DEFAULT_CONFIG, ['api_platform' => ['eager_loading' => ['enabled' => false]]]), $containerBuilder);
     }