chore: add missing deprecation notices to ParameterValidator (#6655)

Co-authored-by: soyuka <[email protected]>

Author: dunglas

src/ParameterValidator/Exception/ValidationException.php

@@ -18,6 +18,8 @@
 /**
  * Filter validation exception.
  *
+ * @deprecated use \ApiPlatform\Metadata\Parameter::$constraints instead
+ *
  * @author Julien DENIAU <[email protected]>
  */
 final class ValidationException extends \Exception implements ValidationExceptionInterface, ProblemExceptionInterface
@@ -28,6 +30,8 @@ final class ValidationException extends \Exception implements ValidationExceptio
     public function __construct(private readonly array $constraintViolationList, string $message = '', int $code = 0, ?\Exception $previous = null)
     {
         parent::__construct($message ?: $this->__toString(), $code, $previous);
+
+        trigger_deprecation('api-platform/core', '3.4', 'The class "%s" is deprecated, use "\ApiPlatform\Metadata\Parameter::$constraints" instead.', __CLASS__);
     }
 
     public function getConstraintViolationList(): array

src/ParameterValidator/Exception/ValidationExceptionInterface.php

@@ -17,6 +17,8 @@
 
 /**
  * This Exception is thrown when any parameter validation fails.
+ *
+ * @deprecated use \ApiPlatform\Metadata\Parameter::$constraints instead
  */
 interface ValidationExceptionInterface extends ExceptionInterface, \Stringable
 {

src/ParameterValidator/FilterLocatorTrait.php

@@ -20,11 +20,9 @@
 /**
  * Manipulates filters with a backward compatibility between the new filter locator and the deprecated filter collection.
  *
- * @author Baptiste Meyer <[email protected]>
- *
- * @deprecated
- *
  * @internal
+ *
+ * @author Baptiste Meyer <[email protected]>
  */
 trait FilterLocatorTrait
 {

src/ParameterValidator/ParameterValidator.php

@@ -26,6 +26,8 @@
 /**
  * Validates parameters depending on filter description.
  *
+ * @deprecated use \ApiPlatform\Metadata\Parameter::$constraints instead
+ *
  * @author Julien Deniau <[email protected]>
  */
 class ParameterValidator
@@ -36,6 +38,8 @@ class ParameterValidator
 
     public function __construct(ContainerInterface $filterLocator)
     {
+        trigger_deprecation('api-platform/core', '3.4', 'The class "%s" is deprecated, use "\ApiPlatform\Metadata\Parameter::$constraints" instead.', __CLASS__);
+
         $this->setFilterLocator($filterLocator);
 
         $this->validators = [

src/ParameterValidator/Tests/ParameterValidatorTest.php

@@ -23,6 +23,8 @@
 use Psr\Container\ContainerInterface;
 
 /**
+ * @group legacy
+ *
  * @author Julien Deniau <[email protected]>
  */
 class ParameterValidatorTest extends TestCase

src/ParameterValidator/Tests/Validator/ArrayItemsTest.php

@@ -17,6 +17,8 @@
 use PHPUnit\Framework\TestCase;
 
 /**
+ * @group legacy
+ *
  * @author Julien Deniau <[email protected]>
  */
 class ArrayItemsTest extends TestCase
@@ -41,9 +43,6 @@ public function testEmptyQueryParameter(): void
         );
     }
 
-    /**
-     * @group legacy
-     */
     public function testNonMatchingParameter(): void
     {
         $filter = new ArrayItems();

src/ParameterValidator/Tests/Validator/BoundsTest.php

@@ -17,6 +17,8 @@
 use PHPUnit\Framework\TestCase;
 
 /**
+ * @group legacy
+ *
  * @author Julien Deniau <[email protected]>
  */
 class BoundsTest extends TestCase
@@ -39,9 +41,6 @@ public function testEmptyQueryParameter(): void
         );
     }
 
-    /**
-     * @group legacy
-     */
     public function testNonMatchingMinimum(): void
     {
         $request = ['some_filter' => '9'];
@@ -124,9 +123,6 @@ public function testNonMatchingMinimumOpenApi(): void
         );
     }
 
-    /**
-     * @group legacy
-     */
     public function testMatchingMinimum(): void
     {
         $request = ['some_filter' => '10'];
@@ -181,9 +177,6 @@ public function testMatchingMinimumOpenApi(): void
         );
     }
 
-    /**
-     * @group legacy
-     */
     public function testNonMatchingMaximum(): void
     {
         $request = ['some_filter' => '11'];
@@ -266,9 +259,6 @@ public function testNonMatchingMaximumOpenApi(): void
         );
     }
 
-    /**
-     * @group legacy
-     */
     public function testMatchingMaximum(): void
     {
         $request = ['some_filter' => '10'];

src/ParameterValidator/Tests/Validator/EnumTest.php

@@ -17,6 +17,8 @@
 use PHPUnit\Framework\TestCase;
 
 /**
+ * @group legacy
+ *
  * @author Julien Deniau <[email protected]>
  */
 class EnumTest extends TestCase
@@ -39,9 +41,6 @@ public function testEmptyQueryParameter(): void
         );
     }
 
-    /**
-     * @group legacy
-     */
     public function testNonMatchingParameter(): void
     {
         $filter = new Enum();
@@ -74,9 +73,6 @@ public function testNonMatchingParameterOpenApi(): void
         );
     }
 
-    /**
-     * @group legacy
-     */
     public function testMatchingParameter(): void
     {
         $filter = new Enum();

src/ParameterValidator/Tests/Validator/LengthTest.php

@@ -17,6 +17,8 @@
 use PHPUnit\Framework\TestCase;
 
 /**
+ * @group legacy
+ *
  * @author Julien Deniau <[email protected]>
  */
 class LengthTest extends TestCase
@@ -39,9 +41,6 @@ public function testEmptyQueryParameter(): void
         );
     }
 
-    /**
-     * @group legacy
-     */
     public function testNonMatchingParameter(): void
     {
         $filter = new Length();
@@ -86,9 +85,6 @@ public function testNonMatchingParameterOpenApi(): void
         );
     }
 
-    /**
-     * @group legacy
-     */
     public function testNonMatchingParameterWithOnlyOneDefinition(): void
     {
         $filter = new Length();
@@ -143,9 +139,6 @@ public function testNonMatchingParameterWithOnlyOneDefinitionOpenApi(): void
         );
     }
 
-    /**
-     * @group legacy
-     */
     public function testMatchingParameter(): void
     {
         $filter = new Length();
@@ -194,9 +187,6 @@ public function testMatchingParameterOpenApi(): void
         );
     }
 
-    /**
-     * @group legacy
-     */
     public function testMatchingParameterWithOneDefinition(): void
     {
         $filter = new Length();

src/ParameterValidator/Tests/Validator/MultipleOfTest.php

@@ -17,6 +17,8 @@
 use PHPUnit\Framework\TestCase;
 
 /**
+ * @group legacy
+ *
  * @author Julien Deniau <[email protected]>
  */
 class MultipleOfTest extends TestCase
@@ -40,9 +42,6 @@ public function testEmptyQueryParameter(): void
         );
     }
 
-    /**
-     * @group legacy
-     */
     public function testNonMatchingParameter(): void
     {
         $request = ['some_filter' => '8'];
@@ -77,9 +76,6 @@ public function testNonMatchingParameterOpenApi(): void
         );
     }
 
-    /**
-     * @group legacy
-     */
     public function testMatchingParameter(): void
     {
         $request = ['some_filter' => '8'];