fix(symfony): object typed property schema collection restriction (#6823)

Author: c1tru55

src/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaCollectionRestriction.php

@@ -40,7 +40,7 @@ public function create(Constraint $constraint, ApiProperty $propertyMetadata): a
     {
         $restriction = [
             'type' => 'object',
-            'properties' => [],
+            'properties' => new \ArrayObject(),
             'additionalProperties' => $constraint->allowExtraFields,
         ];
         $required = [];

tests/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaCollectionRestrictionTest.php

@@ -79,7 +79,7 @@ public function testCreate(Constraint $constraint, ApiProperty $propertyMetadata
 
     public static function createProvider(): \Generator
     {
-        yield 'empty' => [new Collection([]), new ApiProperty(), ['type' => 'object', 'properties' => [], 'additionalProperties' => false]];
+        yield 'empty' => [new Collection([]), new ApiProperty(), ['type' => 'object', 'properties' => new \ArrayObject(), 'additionalProperties' => false]];
 
         $fields = [
             'name' => new Required([
@@ -104,13 +104,13 @@ public static function createProvider(): \Generator
                 ],
             ]),
         ];
-        $properties = [
+        $properties = new \ArrayObject([
             'name' => new \ArrayObject(),
             'email' => ['minLength' => 2, 'maxLength' => 255, 'format' => 'email'],
             'phone' => ['pattern' => '^([+]*[(]{0,1}[0-9]{1,4}[)]{0,1}[-\s\./0-9]*)$'],
             'age' => ['exclusiveMinimum' => 0],
-            'social' => ['type' => 'object', 'properties' => ['githubUsername' => new \ArrayObject()], 'additionalProperties' => false, 'required' => ['githubUsername']],
-        ];
+            'social' => ['type' => 'object', 'properties' => new \ArrayObject(['githubUsername' => new \ArrayObject()]), 'additionalProperties' => false, 'required' => ['githubUsername']],
+        ]);
         $required = ['name', 'email', 'social'];
 
         yield 'with fields' => [

tests/Symfony/Validator/Metadata/Property/ValidatorPropertyMetadataFactoryTest.php

@@ -630,7 +630,7 @@ public function testCreateWithPropertyCollectionRestriction(): void
 
         $this->assertEquals([
             'type' => 'object',
-            'properties' => [
+            'properties' => new \ArrayObject([
                 'name' => new \ArrayObject(),
                 'email' => ['format' => 'email', 'minLength' => 2, 'maxLength' => 255],
                 'phone' => ['pattern' => '^([+]*[(]{0,1}[0-9]{1,4}[)]{0,1}[-\s\./0-9]*)$'],
@@ -639,13 +639,13 @@ public function testCreateWithPropertyCollectionRestriction(): void
                 ],
                 'social' => [
                     'type' => 'object',
-                    'properties' => [
+                    'properties' => new \ArrayObject([
                         'githubUsername' => new \ArrayObject(),
-                    ],
+                    ]),
                     'additionalProperties' => false,
                     'required' => ['githubUsername'],
                 ],
-            ],
+            ]),
             'additionalProperties' => true,
             'required' => ['name', 'email', 'social'],
         ], $schema);