Apply Vincent's review updates

`src/Serializer/AbstractItemNormalizer.php`: Update constant name
Change author phpdoc on test documents and entities

Author: silverbackdan

src/JsonLd/Serializer/ItemNormalizer.php

@@ -67,7 +67,7 @@ public function normalize($object, $format = null, array $context = [])
     {
         $objectClass = $this->getObjectClass($object);
         $outputClass = $this->getOutputClass($objectClass, $context);
-        if (null !== $outputClass && !isset($context[self::IS_TRANSFORMED_TO_SAME_CLASS_CONTEXT_KEY])) {
+        if (null !== $outputClass && !isset($context[self::IS_TRANSFORMED_TO_SAME_CLASS])) {
             return parent::normalize($object, $format, $context);
         }
 

src/Serializer/AbstractItemNormalizer.php

@@ -51,7 +51,7 @@ abstract class AbstractItemNormalizer extends AbstractObjectNormalizer
     use ContextTrait;
     use InputOutputMetadataTrait;
 
-    public const IS_TRANSFORMED_TO_SAME_CLASS_CONTEXT_KEY = 'is_transformed_to_same_class';
+    public const IS_TRANSFORMED_TO_SAME_CLASS = 'is_transformed_to_same_class';
 
     protected $propertyNameCollectionFactory;
     protected $propertyMetadataFactory;
@@ -114,7 +114,7 @@ public function hasCacheableSupportsMethod(): bool
      */
     public function normalize($object, $format = null, array $context = [])
     {
-        if (!($isTransformed = isset($context[self::IS_TRANSFORMED_TO_SAME_CLASS_CONTEXT_KEY])) && $outputClass = $this->getOutputClass($this->getObjectClass($object), $context)) {
+        if (!($isTransformed = isset($context[self::IS_TRANSFORMED_TO_SAME_CLASS])) && $outputClass = $this->getOutputClass($this->getObjectClass($object), $context)) {
             if (!$this->serializer instanceof NormalizerInterface) {
                 throw new LogicException('Cannot normalize the output because the injected serializer is not a normalizer');
             }
@@ -124,13 +124,13 @@ public function normalize($object, $format = null, array $context = [])
                 $context['api_resource'] = $object;
                 unset($context['output'], $context['resource_class']);
             } else {
-                $context[self::IS_TRANSFORMED_TO_SAME_CLASS_CONTEXT_KEY] = true;
+                $context[self::IS_TRANSFORMED_TO_SAME_CLASS] = true;
             }
 
             return $this->serializer->normalize($transformed, $format, $context);
         }
         if ($isTransformed) {
-            unset($context[self::IS_TRANSFORMED_TO_SAME_CLASS_CONTEXT_KEY]);
+            unset($context[self::IS_TRANSFORMED_TO_SAME_CLASS]);
         }
 
         $resourceClass = $this->resourceClassResolver->getResourceClass($object, $context['resource_class'] ?? null);

tests/Fixtures/TestBundle/Document/DummyDtoOutputFallbackToSameClass.php

@@ -20,7 +20,7 @@
 /**
  * Dummy InputOutput.
  *
- * @author Kévin Dunglas <[email protected]>
+ * @author Daniel West <[email protected]>
  *
  * @ApiResource(attributes={"output"=OutputDtoDummy::class})
  * @ODM\Document

tests/Fixtures/TestBundle/Document/DummyDtoOutputSameClass.php

@@ -19,7 +19,7 @@
 /**
  * Dummy InputOutput.
  *
- * @author Kévin Dunglas <[email protected]>
+ * @author Daniel West <[email protected]>
  *
  * @ApiResource(attributes={"output"=DummyDtoOutputSameClass::class})
  * @ODM\Document

tests/Fixtures/TestBundle/Entity/DummyDtoOutputFallbackToSameClass.php

@@ -20,7 +20,7 @@
 /**
  * Dummy InputOutput.
  *
- * @author Kévin Dunglas <[email protected]>
+ * @author Daniel West <[email protected]>
  *
  * @ApiResource(attributes={"output"=OutputDtoDummy::class})
  * @ORM\Entity

tests/Fixtures/TestBundle/Entity/DummyDtoOutputSameClass.php

@@ -19,7 +19,7 @@
 /**
  * Dummy InputOutput.
  *
- * @author Kévin Dunglas <[email protected]>
+ * @author Daniel West <[email protected]>
  *
  * @ApiResource(attributes={"output"=DummyDtoOutputSameClass::class})
  * @ORM\Entity