Use is_iterable function where possible

Author: teohhanhui

src/Bridge/Doctrine/EventListener/PurgeHttpCacheListener.php

@@ -133,7 +133,7 @@ private function addTagsFor($value)
             return;
         }
 
-        if (!\is_array($value) && !$value instanceof \Traversable) {
+        if (!is_iterable($value)) {
             $this->addTagForItem($value);
 
             return;

src/GraphQl/Type/Definition/IterableType.php

@@ -46,8 +46,7 @@ public function __construct()
      */
     public function serialize($value)
     {
-        // is_iterable
-        if (!(\is_array($value) || $value instanceof \Traversable)) {
+        if (!is_iterable($value)) {
             throw new Error(sprintf('Iterable cannot represent non iterable value: %s', Utils::printSafe($value)));
         }
 
@@ -59,8 +58,7 @@ public function serialize($value)
      */
     public function parseValue($value)
     {
-        // is_iterable
-        if (!(\is_array($value) || $value instanceof \Traversable)) {
+        if (!is_iterable($value)) {
             throw new Error(sprintf('Iterable cannot represent non iterable value: %s', Utils::printSafeJson($value)));
         }
 

src/Hydra/Serializer/CollectionNormalizer.php

@@ -56,7 +56,7 @@ public function __construct(ContextBuilderInterface $contextBuilder, ResourceCla
      */
     public function supportsNormalization($data, $format = null)
     {
-        return self::FORMAT === $format && (\is_array($data) || ($data instanceof \Traversable));
+        return self::FORMAT === $format && is_iterable($data);
     }
 
     /**

src/Serializer/AbstractCollectionNormalizer.php

@@ -50,7 +50,7 @@ public function __construct(ResourceClassResolverInterface $resourceClassResolve
      */
     public function supportsNormalization($data, $format = null)
     {
-        return static::FORMAT === $format && (\is_array($data) || $data instanceof \Traversable);
+        return static::FORMAT === $format && is_iterable($data);
     }
 
     /**

src/Serializer/AbstractItemNormalizer.php

@@ -403,7 +403,7 @@ protected function getAttributeValue($object, $attribute, $format = null, array
         $type = $propertyMetadata->getType();
 
         if (
-            (\is_array($attributeValue) || $attributeValue instanceof \Traversable) &&
+            is_iterable($attributeValue) &&
             $type &&
             $type->isCollection() &&
             ($collectionValueType = $type->getCollectionValueType()) &&

tests/DataProvider/ChainCollectionDataProviderTest.php

@@ -69,7 +69,7 @@ public function testGetCollectionNotSupported()
 
         $collection = (new ChainCollectionDataProvider([$firstDataProvider->reveal()]))->getCollection('notfound', 'op');
 
-        $this->assertContains(true, [\is_array($collection), $collection instanceof \Traversable]);
+        $this->assertTrue(is_iterable($collection));
         $this->assertEmpty($collection);
     }
 
@@ -109,15 +109,15 @@ public function testLegacyGetCollectionExceptions()
 
         $collection = (new ChainCollectionDataProvider([$firstDataProvider->reveal()]))->getCollection('notfound', 'op');
 
-        $this->assertContains(true, [\is_array($collection), $collection instanceof \Traversable]);
+        $this->assertTrue(is_iterable($collection));
         $this->assertEmpty($collection);
     }
 
     public function testGetCollectionWithEmptyDataProviders()
     {
         $collection = (new ChainCollectionDataProvider([]))->getCollection(Dummy::class);
 
-        $this->assertContains(true, [\is_array($collection), $collection instanceof \Traversable]);
+        $this->assertTrue(is_iterable($collection));
         $this->assertEmpty($collection);
     }
 }