Merge pull request #2646 from bpolaszek/2.4

Ensure unsuccessful responses are not cached

Author: dunglas

src/HttpCache/EventListener/AddHeadersListener.php

@@ -52,7 +52,7 @@ public function onKernelResponse(FilterResponseEvent $event): void
 
         $response = $event->getResponse();
 
-        if (!$response->getContent()) {
+        if (!$response->getContent() || !$response->isSuccessful()) {
             return;
         }
 

tests/HttpCache/EventListener/AddHeadersListenerTest.php

@@ -44,6 +44,22 @@ public function testDoNotSetHeaderWhenMethodNotCacheable()
         $this->assertNull($response->getEtag());
     }
 
+    public function testDoNotSetHeaderOnUnsuccessfulResponse()
+    {
+        $request = new Request([], [], ['_api_resource_class' => Dummy::class, '_api_item_operation_name' => 'get']);
+
+        $response = new Response('{}', Response::HTTP_BAD_REQUEST);
+
+        $event = $this->prophesize(FilterResponseEvent::class);
+        $event->getRequest()->willReturn($request)->shouldBeCalled();
+        $event->getResponse()->willReturn($response)->shouldBeCalled();
+
+        $listener = new AddHeadersListener(true);
+        $listener->onKernelResponse($event->reveal());
+
+        $this->assertNull($response->getEtag());
+    }
+
     public function testDoNotSetHeaderWhenNotAnApiOperation()
     {
         $request = new Request();