fix(symfony): error wrongly inherit normalization context (#6939)

Author: soyuka

src/Symfony/EventListener/ErrorListener.php

@@ -94,7 +94,7 @@ protected function duplicateRequest(\Throwable $exception, Request $request): Re
             $operation = $operation->withProvider('api_platform.state.error_provider');
         }
 
-        $normalizationContext = ($operation->getNormalizationContext() ?? []) + ($apiOperation?->getNormalizationContext() ?? []);
+        $normalizationContext = $operation->getNormalizationContext() ?? [];
         if (!($normalizationContext['api_error_resource'] ?? false)) {
             $normalizationContext += ['api_error_resource' => true];
         }

tests/Fixtures/TestBundle/ApiResource/Issue6926/Error.php

@@ -0,0 +1,46 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\Issue6926;
+
+use ApiPlatform\Metadata\ErrorResource;
+use ApiPlatform\Metadata\Exception\ProblemExceptionInterface;
+
+#[ErrorResource]
+class Error extends \Exception implements ProblemExceptionInterface
+{
+    public function getType(): string
+    {
+        return '/errors/demo-error';
+    }
+
+    public function getTitle(): ?string
+    {
+        return 'Demo error';
+    }
+
+    public function getStatus(): ?int
+    {
+        return 400;
+    }
+
+    public function getDetail(): ?string
+    {
+        return 'This should be returned in the response.';
+    }
+
+    public function getInstance(): ?string
+    {
+        return null;
+    }
+}

tests/Fixtures/TestBundle/ApiResource/Issue6926/ThrowsAnExceptionWithGroup.php

@@ -0,0 +1,40 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\Issue6926;
+
+use ApiPlatform\Metadata\Post;
+use Symfony\Component\Serializer\Attribute\Groups;
+
+#[Post(
+    uriTemplate: '/issue6926',
+    processor: [self::class, 'process'],
+    denormalizationContext: ['groups' => ['login_request:write']],
+    normalizationContext: ['groups' => ['login_request:read']],
+    errors: [Error::class]
+)]
+class ThrowsAnExceptionWithGroup
+{
+    #[Groups('login_request:read')]
+    private ?string $id = null;
+
+    public function getId(): ?string
+    {
+        return $this->id;
+    }
+
+    public static function process(): void
+    {
+        throw new Error();
+    }
+}

tests/Functional/Issues/Issue6926Test.php

@@ -0,0 +1,38 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Functional\Issues;
+
+use ApiPlatform\Symfony\Bundle\Test\ApiTestCase;
+use ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\Issue6926\Error;
+use ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\Issue6926\ThrowsAnExceptionWithGroup;
+use ApiPlatform\Tests\SetupClassResourcesTrait;
+
+class Issue6926Test extends ApiTestCase
+{
+    use SetupClassResourcesTrait;
+
+    /**
+     * @return class-string[]
+     */
+    public static function getResources(): array
+    {
+        return [ThrowsAnExceptionWithGroup::class, Error::class];
+    }
+
+    public function testWithGroupFilter(): void
+    {
+        $response = self::createClient()->request('POST', '/issue6926', ['json' => []]);
+        $this->assertEquals('This should be returned in the response.', $response->toArray(false)['detail'] ?? false);
+    }
+}