chore(deprecation): remove identifiers complexity

Author: soyuka

src/Api/IdentifiersExtractor.php

@@ -141,38 +141,10 @@ private function resolveIdentifierValue($identifierValue, string $parameterName)
             return $identifierValue;
         }
 
-        // TODO: php 8 remove method_exists
-        if (method_exists($identifierValue, '__toString') || $identifierValue instanceof \Stringable) {
+        if ($identifierValue instanceof \Stringable) {
             return (string) $identifierValue;
         }
 
-        // TODO: remove this in 3.0
-        // we could recurse to find correct identifiers until there it is a scalar but this is not really supported and adds a lot of complexity
-        // instead we're deprecating this behavior in favor of something that can be transformed to a string
-        if ($this->isResourceClass($relatedResourceClass = $this->getObjectClass($identifierValue))) {
-            trigger_deprecation('api-platform/core', '2.7', 'Using a resource class as identifier is deprecated, please make this identifier Stringable');
-            $relatedOperation = $this->resourceMetadataFactory->create($relatedResourceClass)->getOperation();
-
-            $relatedLinks = [];
-            if ($relatedOperation instanceof GraphQlOperation) {
-                $relatedLinks = $relatedOperation->getLinks();
-            } elseif ($relatedOperation instanceof HttpOperation) {
-                $relatedLinks = $relatedOperation->getUriVariables();
-            }
-
-            if (1 === \count($relatedLinks)) {
-                $identifierValue = $this->getIdentifierValue($identifierValue, $relatedResourceClass, current($relatedLinks)->getIdentifiers()[0], $parameterName);
-
-                if (\is_scalar($identifierValue)) {
-                    return $identifierValue;
-                }
-
-                if ($identifierValue instanceof \Stringable || method_exists($identifierValue, '__toString')) {
-                    return (string) $identifierValue;
-                }
-            }
-        }
-
         throw new RuntimeException(sprintf('We were not able to resolve the identifier matching parameter "%s".', $parameterName));
     }
 }

tests/Fixtures/TestBundle/Document/DummyFriend.php

@@ -79,4 +79,9 @@ public function setName(string $name)
     {
         $this->name = $name;
     }
+
+    public function __toString()
+    {
+        return (string) $this->getId();
+    }
 }

tests/Fixtures/TestBundle/Document/RelatedDummy.php

@@ -178,4 +178,9 @@ public function setEmbeddedDummy(EmbeddableDummy $embeddedDummy)
     {
         $this->embeddedDummy = $embeddedDummy;
     }
+
+    public function __toString()
+    {
+        return (string) $this->getId();
+    }
 }

tests/Fixtures/TestBundle/Entity/DummyFriend.php

@@ -81,4 +81,9 @@ public function setName(string $name)
     {
         $this->name = $name;
     }
+
+    public function __toString()
+    {
+        return (string) $this->getId();
+    }
 }

tests/Fixtures/TestBundle/Entity/RelatedDummy.php

@@ -188,4 +188,9 @@ public function setEmbeddedDummy(EmbeddableDummy $embeddedDummy)
     {
         $this->embeddedDummy = $embeddedDummy;
     }
+
+    public function __toString()
+    {
+        return (string) $this->getId();
+    }
 }