fix: remove collection_operation_name legacy key

Author: vincentchalamon

src/Doctrine/Orm/Extension/PaginationExtension.php

@@ -134,7 +134,7 @@ private function shouldDoctrinePaginatorFetchJoinCollection(QueryBuilder $queryB
     {
         $fetchJoinCollection = $operation?->getPaginationFetchJoinCollection();
 
-        if ((isset($context['collection_operation_name']) || isset($context['operation_name'])) && isset($fetchJoinCollection)) {
+        if (isset($context['operation_name']) && isset($fetchJoinCollection)) {
             return $fetchJoinCollection;
         }
 
@@ -167,7 +167,7 @@ private function shouldDoctrinePaginatorUseOutputWalkers(QueryBuilder $queryBuil
     {
         $useOutputWalkers = $operation?->getPaginationUseOutputWalkers();
 
-        if ((isset($context['collection_operation_name']) || isset($context['operation_name'])) && isset($useOutputWalkers)) {
+        if (isset($context['operation_name']) && isset($useOutputWalkers)) {
             return $useOutputWalkers;
         }
 

tests/Doctrine/Orm/Extension/PaginationExtensionTest.php

@@ -398,8 +398,8 @@ public function testGetResultWithFetchJoinCollection(bool $paginationFetchJoinCo
     public function fetchJoinCollectionProvider(): array
     {
         return [
-            'collection disabled' => [false, ['collection_operation_name' => 'get'], false],
-            'collection enabled' => [true, ['collection_operation_name' => 'get'], true],
+            'collection disabled' => [false, ['operation_name' => 'get'], false],
+            'collection enabled' => [true, ['operation_name' => 'get'], true],
             'graphql disabled' => [false, ['graphql_operation_name' => 'query'], false],
             'graphql enabled' => [true, ['graphql_operation_name' => 'query'], true],
         ];
@@ -448,8 +448,8 @@ public function testGetResultWithUseOutputWalkers(bool $paginationUseOutputWalke
     public function fetchUseOutputWalkersProvider(): array
     {
         return [
-            'collection disabled' => [false, ['collection_operation_name' => 'get'], false],
-            'collection enabled' => [true, ['collection_operation_name' => 'get'], true],
+            'collection disabled' => [false, ['operation_name' => 'get'], false],
+            'collection enabled' => [true, ['operation_name' => 'get'], true],
             'graphql disabled' => [false, ['graphql_operation_name' => 'query'], false],
             'graphql enabled' => [true, ['graphql_operation_name' => 'query'], true],
         ];

tests/Symfony/EventListener/SerializeListenerTest.php

@@ -116,7 +116,7 @@ public function testDoNotSerializeWhenDisabledInOperationAttribute()
 
     public function testSerializeCollectionOperation()
     {
-        $expectedContext = ['request_uri' => '', 'resource_class' => 'Foo', 'collection_operation_name' => 'get'];
+        $expectedContext = ['request_uri' => '', 'resource_class' => 'Foo', 'operation_name' => 'get'];
         $serializerProphecy = $this->prophesize(SerializerInterface::class);
 
         $serializerProphecy
@@ -129,7 +129,7 @@ public function testSerializeCollectionOperation()
                     }),
                     Argument::withEntry('request_uri', ''),
                     Argument::withEntry('resource_class', 'Foo'),
-                    Argument::withEntry('collection_operation_name', 'get')
+                    Argument::withEntry('operation_name', 'get')
                 )
             )
             ->willReturn('bar')
@@ -155,7 +155,7 @@ public function testSerializeCollectionOperation()
 
     public function testSerializeCollectionOperationWithOutputClassDisabled()
     {
-        $expectedContext = ['request_uri' => '', 'resource_class' => 'Foo', 'collection_operation_name' => 'post', 'output' => ['class' => null]];
+        $expectedContext = ['request_uri' => '', 'resource_class' => 'Foo', 'operation_name' => 'post', 'output' => ['class' => null]];
         $serializerProphecy = $this->prophesize(SerializerInterface::class);
 
         $serializerContextBuilderProphecy = $this->prophesize(SerializerContextBuilderInterface::class);