Merge pull request #3417 from arnedesmedt/enableDecoratingSchemaFactory

teohhanhui · web-flow · commit 6578c8b86755 · 2020-03-02T17:36:30.000+01:00
Don't typehint the SchemaFactory decorator by its implementation, but by its interface
diff --git a/src/Hydra/JsonSchema/SchemaFactory.php b/src/Hydra/JsonSchema/SchemaFactory.php
@@ -38,10 +38,13 @@ final class SchemaFactory implements SchemaFactoryInterface
 
     private $schemaFactory;
 
-    public function __construct(BaseSchemaFactory $schemaFactory)
+    public function __construct(SchemaFactoryInterface $schemaFactory)
     {
         $this->schemaFactory = $schemaFactory;
-        $schemaFactory->addDistinctFormat('jsonld');
+
+        if ($schemaFactory instanceof BaseSchemaFactory) {
+            $schemaFactory->addDistinctFormat('jsonld');
+        }
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -38,10 +38,13 @@ final class SchemaFactory implements SchemaFactoryInterface`
`38`	`38`
`39`	`39`	`private $schemaFactory;`
`40`	`40`
`41`		`- public function __construct(BaseSchemaFactory $schemaFactory)`
	`41`	`+ public function __construct(SchemaFactoryInterface $schemaFactory)`
`42`	`42`	`{`
`43`	`43`	`$this->schemaFactory = $schemaFactory;`
`44`		`- $schemaFactory->addDistinctFormat('jsonld');`
	`44`	`+`
	`45`	`+ if ($schemaFactory instanceof BaseSchemaFactory) {`
	`46`	`+ $schemaFactory->addDistinctFormat('jsonld');`
	`47`	`+ }`
`45`	`48`	`}`
`46`	`49`
`47`	`50`	`/**`