chore: enable bc rules in php-cs-fixer (#4873)

Author: alanpoulain

.php-cs-fixer.dist.php

@@ -75,10 +75,9 @@
             ],
         ],
         'no_superfluous_elseif' => true,
-        // To re-enable in API Platform 3: https://github.com/symfony/symfony/issues/43021
-        //'no_superfluous_phpdoc_tags' => [
-        //    'allow_mixed' => false,
-        //],
+        'no_superfluous_phpdoc_tags' => [
+            'allow_mixed' => false,
+        ],
         'no_unset_cast' => true,
         'no_unset_on_property' => true,
         'no_useless_else' => true,
@@ -114,6 +113,5 @@
                 'property',
             ],
         ],
-        'void_return' => false, // BC breaks; to be done in API Platform 3.0
     ])
     ->setFinder($finder);

src/Action/NotFoundAction.php

@@ -20,7 +20,7 @@
  */
 final class NotFoundAction
 {
-    public function __invoke()
+    public function __invoke(): void
     {
         throw new NotFoundHttpException();
     }

src/Api/IdentifiersExtractor.php

@@ -83,8 +83,6 @@ public function getIdentifiersFromItem($item, Operation $operation = null, array
 
     /**
      * Gets the value of the given class property.
-     *
-     * @param mixed $item
      */
     private function getIdentifierValue($item, string $class, string $property, string $parameterName)
     {

src/Api/ResourceClassResolverInterface.php

@@ -27,7 +27,6 @@ interface ResourceClassResolverInterface
      *
      * @param string $resourceClass The expected resource class
      * @param bool   $strict        If true, value must match the expected resource class
-     * @param mixed  $value
      *
      * @throws InvalidArgumentException
      */

src/Doctrine/Common/State/PersistProcessor.php

@@ -47,8 +47,6 @@ public function process($data, Operation $operation, array $uriVariables = [], a
 
     /**
      * Gets the Doctrine object manager associated with given data.
-     *
-     * @param mixed $data
      */
     private function getManager($data): ?DoctrineObjectManager
     {
@@ -57,8 +55,6 @@ private function getManager($data): ?DoctrineObjectManager
 
     /**
      * Checks if doctrine does not manage data automatically.
-     *
-     * @param mixed $data
      */
     private function isDeferredExplicit(DoctrineObjectManager $manager, $data): bool
     {

src/Doctrine/Common/State/RemoveProcessor.php

@@ -39,8 +39,6 @@ public function process($data, Operation $operation, array $uriVariables = [], a
 
     /**
      * Gets the Doctrine object manager associated with given data.
-     *
-     * @param mixed $data
      */
     private function getManager($data): ?DoctrineObjectManager
     {

src/Doctrine/Odm/Filter/AbstractFilter.php

@@ -54,8 +54,6 @@ public function apply(Builder $aggregationBuilder, string $resourceClass, Operat
 
     /**
      * Passes a property through the filter.
-     *
-     * @param mixed $value
      */
     abstract protected function filterProperty(string $property, $value, Builder $aggregationBuilder, string $resourceClass, Operation $operation = null, array &$context = []);
 

src/Doctrine/Odm/Filter/DateFilter.php

@@ -108,8 +108,6 @@ protected function filterProperty(string $property, $values, Builder $aggregatio
 
     /**
      * Adds the match stage according to the chosen null management.
-     *
-     * @param mixed $value
      */
     private function addMatch(Builder $aggregationBuilder, string $field, string $operator, $value, string $nullManagement = null): void
     {

src/Doctrine/Orm/Filter/AbstractFilter.php

@@ -46,8 +46,6 @@ public function apply(QueryBuilder $queryBuilder, QueryNameGeneratorInterface $q
 
     /**
      * Passes a property through the filter.
-     *
-     * @param mixed $value
      */
     abstract protected function filterProperty(string $property, $value, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, Operation $operation = null, array $context = []);
 

src/Elasticsearch/Serializer/ItemNormalizer.php

@@ -97,7 +97,7 @@ public function supportsNormalization(mixed $data, string $format = null, array
      *
      * @throws LogicException
      */
-    public function setSerializer(SerializerInterface $serializer)
+    public function setSerializer(SerializerInterface $serializer): void
     {
         if (!$this->decorated instanceof SerializerAwareInterface) {
             throw new LogicException(sprintf('The decorated normalizer must be an instance of "%s".', SerializerAwareInterface::class));