Merge pull request #2648 from api-platform/revert-2629-fix/cache-in-dev

Revert "Do not disable cache in dev"

Author: teohhanhui

src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php

@@ -436,21 +436,17 @@ private function registerBundlesConfiguration(array $bundles, array $config, Xml
      */
     private function registerCacheConfiguration(ContainerBuilder $container)
     {
-        if (!$container->hasParameter('api_platform.metadata_cache')) {
+        // Don't use system cache pool in dev
+        if ($container->hasParameter('api_platform.metadata_cache') ? $container->getParameter('api_platform.metadata_cache') : !$container->getParameter('kernel.debug')) {
             return;
         }
 
-        @trigger_error('The "api_platform.metadata_cache" parameter is deprecated since version 2.4 and will have no effect in 3.0.', E_USER_DEPRECATED);
-
-        // BC
-        if (!$container->getParameter('api_platform.metadata_cache')) {
-            $container->register('api_platform.cache.metadata.property', ArrayAdapter::class);
-            $container->register('api_platform.cache.metadata.resource', ArrayAdapter::class);
-            $container->register('api_platform.cache.route_name_resolver', ArrayAdapter::class);
-            $container->register('api_platform.cache.identifiers_extractor', ArrayAdapter::class);
-            $container->register('api_platform.cache.subresource_operation_factory', ArrayAdapter::class);
-            $container->register('api_platform.elasticsearch.cache.metadata.document', ArrayAdapter::class);
-        }
+        $container->register('api_platform.cache.metadata.property', ArrayAdapter::class);
+        $container->register('api_platform.cache.metadata.resource', ArrayAdapter::class);
+        $container->register('api_platform.cache.route_name_resolver', ArrayAdapter::class);
+        $container->register('api_platform.cache.identifiers_extractor', ArrayAdapter::class);
+        $container->register('api_platform.cache.subresource_operation_factory', ArrayAdapter::class);
+        $container->register('api_platform.elasticsearch.cache.metadata.document', ArrayAdapter::class);
     }
 
     /**

tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php

@@ -1035,7 +1035,8 @@ private function getBaseContainerBuilderProphecy()
             $containerBuilderProphecy->setAlias($alias, $service)->shouldBeCalled();
         }
 
-        $containerBuilderProphecy->hasParameter('api_platform.metadata_cache')->willReturn(false);
+        $containerBuilderProphecy->hasParameter('api_platform.metadata_cache')->willReturn(true)->shouldBeCalled();
+        $containerBuilderProphecy->getParameter('api_platform.metadata_cache')->willReturn(true)->shouldBeCalled();
 
         $containerBuilderProphecy->getDefinition('api_platform.mercure.listener.response.add_link_header')->willReturn(new Definition());
 

tests/Fixtures/app/config/config_common.yml

@@ -89,6 +89,8 @@ api_platform:
 parameters:
     container.autowiring.strict_mode: true
     container.dumper.inline_class_loader: true
+    # Enable the metadata cache to speedup the builds
+    api_platform.metadata_cache: true
 
 services:
     contain_non_resource.item_data_provider: