chore(symfony): remove deprecated test

Author: soyuka

src/Symfony/Security/ResourceAccessChecker.php

@@ -37,9 +37,7 @@ public function isGranted(string $resourceClass, string $expression, array $extr
         if (null === $this->tokenStorage || null === $this->authenticationTrustResolver) {
             throw new \LogicException('The "symfony/security" library must be installed to use the "security" attribute.');
         }
-        if (null === $token = $this->tokenStorage->getToken()) {
-            $token = new NullToken();
-        }
+
         if (null === $this->expressionLanguage) {
             throw new \LogicException('The "symfony/expression-language" library must be installed to use the "security" attribute.');
         }
@@ -49,10 +47,12 @@ public function isGranted(string $resourceClass, string $expression, array $extr
             'auth_checker' => $this->authorizationChecker, // needed for the is_granted expression function
         ]);
 
-        if ($token) {
-            $variables = array_merge($variables, $this->getVariables($token));
+        if (null === $token = $this->tokenStorage->getToken()) {
+            $token = new NullToken();
         }
 
+        $variables = array_merge($variables, $this->getVariables($token));
+
         return (bool) $this->expressionLanguage->evaluate($expression, $variables);
     }
 

tests/Symfony/Security/ResourceAccessCheckerTest.php

@@ -83,19 +83,7 @@ public function testExpressionLanguageNotInstalled(): void
         $checker->isGranted(Dummy::class, 'is_granted("ROLE_ADMIN")');
     }
 
-    public function testNotBehindAFirewall(): void
-    {
-        $this->expectException(\LogicException::class);
-        $this->expectExceptionMessage('The current token must be set to use the "security" attribute (is the URL behind a firewall?).');
-
-        $authenticationTrustResolverProphecy = $this->prophesize(AuthenticationTrustResolverInterface::class);
-        $tokenStorageProphecy = $this->prophesize(TokenStorageInterface::class);
-
-        $checker = new ResourceAccessChecker(null, $authenticationTrustResolverProphecy->reveal(), null, $tokenStorageProphecy->reveal());
-        $checker->isGranted(Dummy::class, 'is_granted("ROLE_ADMIN")');
-    }
-
-    public function testWithoutAuthenticationTokenAndExceptionOnNoTokenIsFalse(): void
+    public function testWithoutAuthenticationToken(): void
     {
         $expressionLanguageProphecy = $this->prophesize(ExpressionLanguage::class);
         $expressionLanguageProphecy->evaluate('is_granted("ROLE_ADMIN")', Argument::type('array'))->willReturn(true)->shouldBeCalled();
@@ -106,7 +94,7 @@ public function testWithoutAuthenticationTokenAndExceptionOnNoTokenIsFalse(): vo
 
         $tokenStorageProphecy->getToken()->willReturn(null);
 
-        $checker = new ResourceAccessChecker($expressionLanguageProphecy->reveal(), $authenticationTrustResolverProphecy->reveal(), null, $tokenStorageProphecy->reveal(), $authorizationCheckerProphecy->reveal(), false);
+        $checker = new ResourceAccessChecker($expressionLanguageProphecy->reveal(), $authenticationTrustResolverProphecy->reveal(), null, $tokenStorageProphecy->reveal(), $authorizationCheckerProphecy->reveal());
         self::assertTrue($checker->isGranted(Dummy::class, 'is_granted("ROLE_ADMIN")'));
     }
 }