Merge pull request #747 from teohhanhui/searchfilter-case-invalues

Fix SearchFilter case sensitivity for IN values

Author: dunglas

src/Bridge/Doctrine/Orm/Filter/SearchFilter.php

@@ -189,11 +189,12 @@ protected function filterProperty(string $property, $value, QueryBuilder $queryB
                 return;
             }
 
+            $wrapCase = $this->createWrapCase($caseSensitive);
             $valueParameter = $queryNameGenerator->generateParameterName($field);
 
             $queryBuilder
-                ->andWhere(sprintf('%s.%s IN (:%s)', $alias, $field, $valueParameter))
-                ->setParameter($valueParameter, $caseSensitive ? array_map('strtolower', $values) : $values);
+                ->andWhere(sprintf($wrapCase('%s.%s').' IN (:%s)', $alias, $field, $valueParameter))
+                ->setParameter($valueParameter, $caseSensitive ? $values : array_map('strtolower', $values));
         }
 
         // metadata doesn't have the field, nor an association on the field

tests/Bridge/Doctrine/Orm/Filter/SearchFilterTest.php

@@ -422,6 +422,48 @@ public function provideApplyTestData() : array
                     ],
                 ],
             ],
+            'exact (multiple values)' => [
+                [
+                    'id' => null,
+                    'name' => 'exact',
+                ],
+                [
+                    'name' => [
+                        'CaSE',
+                        'SENSitive',
+                    ],
+                ],
+                [
+                    'dql' => sprintf('SELECT o FROM %s o WHERE o.name IN (:name_p1)', Dummy::class),
+                    'parameters' => [
+                        'name_p1' => [
+                            'CaSE',
+                            'SENSitive',
+                        ],
+                    ],
+                ],
+            ],
+            'exact (multiple values; case insensitive)' => [
+                [
+                    'id' => null,
+                    'name' => 'iexact',
+                ],
+                [
+                    'name' => [
+                        'CaSE',
+                        'inSENSitive',
+                    ],
+                ],
+                [
+                    'dql' => sprintf('SELECT o FROM %s o WHERE LOWER(o.name) IN (:name_p1)', Dummy::class),
+                    'parameters' => [
+                        'name_p1' => [
+                            'case',
+                            'insensitive',
+                        ],
+                    ],
+                ],
+            ],
             'invalid property' => [
                 [
                     'id' => null,