Merge pull request #2554 from soyuka/fix-2551

Test ContextBuilder with anonymous objects

Author: soyuka

src/JsonLd/AnonymousContextBuilderInterface.php

@@ -26,5 +26,5 @@ interface AnonymousContextBuilderInterface extends ContextBuilderInterface
      * Creates a JSON-LD context based on the given object.
      * Usually this is used with an Input or Output DTO object.
      */
-    public function getAnonymousResourceContext($object, array $context, int $referenceType = UrlGeneratorInterface::ABS_PATH): array;
+    public function getAnonymousResourceContext($object, array $context = [], int $referenceType = UrlGeneratorInterface::ABS_PATH): array;
 }

src/JsonLd/ContextBuilder.php

@@ -108,7 +108,7 @@ public function getResourceContextUri(string $resourceClass, int $referenceType
     /**
      * {@inheritdoc}
      */
-    public function getAnonymousResourceContext($object, array $context, int $referenceType = UrlGeneratorInterface::ABS_PATH): array
+    public function getAnonymousResourceContext($object, array $context = [], int $referenceType = UrlGeneratorInterface::ABS_PATH): array
     {
         $id = $context['iri'] ?? '_:'.(\function_exists('spl_object_id') ? spl_object_id($object) : spl_object_hash($object));
         $jsonLdContext = [

src/JsonLd/Serializer/JsonLdContextTrait.php

@@ -55,6 +55,6 @@ private function createJsonLdContext(AnonymousContextBuilderInterface $contextBu
 
         $context['jsonld_has_context'] = true;
 
-        return $contextBuilder->getAnonymousResourceContext($object, $context['output']);
+        return $contextBuilder->getAnonymousResourceContext($object, $context['output'] ?? []);
     }
 }

tests/JsonLd/ContextBuilderTest.php

@@ -23,6 +23,7 @@
 use ApiPlatform\Core\Metadata\Resource\Factory\ResourceNameCollectionFactoryInterface;
 use ApiPlatform\Core\Metadata\Resource\ResourceMetadata;
 use ApiPlatform\Core\Metadata\Resource\ResourceNameCollection;
+use ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\Dummy;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\PropertyInfo\Type;
 
@@ -126,4 +127,46 @@ public function testResourceContextWithReverse()
 
         $this->assertEquals($expected, $contextBuilder->getResourceContext($this->entityClass));
     }
+
+    public function testAnonymousResourceContext()
+    {
+        $dummy = new Dummy();
+        $this->propertyNameCollectionFactoryProphecy->create(Dummy::class)->willReturn(new PropertyNameCollection(['dummyPropertyA']));
+        $this->propertyMetadataFactoryProphecy->create(Dummy::class, 'dummyPropertyA')->willReturn(new PropertyMetadata(new Type(Type::BUILTIN_TYPE_STRING), 'Dummy property A', true, true, true, true, false, false, null, null, []));
+
+        $contextBuilder = new ContextBuilder($this->resourceNameCollectionFactoryProphecy->reveal(), $this->resourceMetadataFactoryProphecy->reveal(), $this->propertyNameCollectionFactoryProphecy->reveal(), $this->propertyMetadataFactoryProphecy->reveal(), $this->urlGeneratorProphecy->reveal());
+
+        $iri = '_:'.(\function_exists('spl_object_id') ? spl_object_id($dummy) : spl_object_hash($dummy));
+        $expected = [
+            '@context' => [
+                '@vocab' => '#',
+                'hydra' => 'http://www.w3.org/ns/hydra/core#',
+                'dummyPropertyA' => $iri.'/dummyPropertyA',
+            ],
+            '@id' => $iri,
+        ];
+
+        $this->assertEquals($expected, $contextBuilder->getAnonymousResourceContext($dummy));
+    }
+
+    public function testAnonymousResourceContextWithIri()
+    {
+        $dummy = new Dummy();
+        $this->propertyNameCollectionFactoryProphecy->create(Dummy::class)->willReturn(new PropertyNameCollection(['dummyPropertyA']));
+        $this->propertyMetadataFactoryProphecy->create(Dummy::class, 'dummyPropertyA')->willReturn(new PropertyMetadata(new Type(Type::BUILTIN_TYPE_STRING), 'Dummy property A', true, true, true, true, false, false, null, null, []));
+
+        $contextBuilder = new ContextBuilder($this->resourceNameCollectionFactoryProphecy->reveal(), $this->resourceMetadataFactoryProphecy->reveal(), $this->propertyNameCollectionFactoryProphecy->reveal(), $this->propertyMetadataFactoryProphecy->reveal(), $this->urlGeneratorProphecy->reveal());
+
+        $expected = [
+            '@context' => [
+                '@vocab' => '#',
+                'hydra' => 'http://www.w3.org/ns/hydra/core#',
+                'dummyPropertyA' => '/dummies/dummyPropertyA',
+            ],
+            '@id' => '/dummies',
+            '@type' => 'Dummy',
+        ];
+
+        $this->assertEquals($expected, $contextBuilder->getAnonymousResourceContext($dummy, ['iri' => '/dummies', 'name' => 'Dummy']));
+    }
 }